powerpc/iommu: Move tce_xxx callbacks from ppc_md to iommu_table
This adds a iommu_table_ops struct and puts pointer to it into the iommu_table struct. This moves tce_build/tce_free/tce_get/tce_flush callbacks from ppc_md to the new struct where they really belong to. This adds the requirement for @it_ops to be initialized before calling iommu_init_table() to make sure that we do not leave any IOMMU table with iommu_table_ops uninitialized. This is not a parameter of iommu_init_table() though as there will be cases when iommu_init_table() will not be called on TCE tables, for example - VFIO. This does s/tce_build/set/, s/tce_free/clear/ and removes "tce_" redundant prefixes. This removes tce_xxx_rm handlers from ppc_md but does not add them to iommu_table_ops as this will be done later if we decide to support TCE hypercalls in real mode. This removes _vm callbacks as only virtual mode is supported by now so this also removes @rm parameter. For pSeries, this always uses tce_buildmulti_pSeriesLP/ tce_buildmulti_pSeriesLP. This changes multi callback to fall back to tce_build_pSeriesLP/tce_free_pSeriesLP if FW_FEATURE_MULTITCE is not present. The reason for this is we still have to support "multitce=off" boot parameter in disable_multitce() and we do not want to walk through all IOMMU tables in the system and replace "multi" callbacks with single ones. For powernv, this defines _ops per PHB type which are P5IOC2/IODA1/IODA2. This makes the callbacks for them public. Later patches will extend callbacks for IODA1/2. No change in behaviour is expected. Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
这个提交包含在:
@@ -206,7 +206,7 @@ static int tce_buildmulti_pSeriesLP(struct iommu_table *tbl, long tcenum,
|
||||
int ret = 0;
|
||||
unsigned long flags;
|
||||
|
||||
if (npages == 1) {
|
||||
if ((npages == 1) || !firmware_has_feature(FW_FEATURE_MULTITCE)) {
|
||||
return tce_build_pSeriesLP(tbl, tcenum, npages, uaddr,
|
||||
direction, attrs);
|
||||
}
|
||||
@@ -298,6 +298,9 @@ static void tce_freemulti_pSeriesLP(struct iommu_table *tbl, long tcenum, long n
|
||||
{
|
||||
u64 rc;
|
||||
|
||||
if (!firmware_has_feature(FW_FEATURE_MULTITCE))
|
||||
return tce_free_pSeriesLP(tbl, tcenum, npages);
|
||||
|
||||
rc = plpar_tce_stuff((u64)tbl->it_index, (u64)tcenum << 12, 0, npages);
|
||||
|
||||
if (rc && printk_ratelimit()) {
|
||||
@@ -473,7 +476,6 @@ static int tce_setrange_multi_pSeriesLP_walk(unsigned long start_pfn,
|
||||
return tce_setrange_multi_pSeriesLP(start_pfn, num_pfn, arg);
|
||||
}
|
||||
|
||||
|
||||
#ifdef CONFIG_PCI
|
||||
static void iommu_table_setparms(struct pci_controller *phb,
|
||||
struct device_node *dn,
|
||||
@@ -559,6 +561,12 @@ static void iommu_table_setparms_lpar(struct pci_controller *phb,
|
||||
tbl->it_size = size >> tbl->it_page_shift;
|
||||
}
|
||||
|
||||
struct iommu_table_ops iommu_table_pseries_ops = {
|
||||
.set = tce_build_pSeries,
|
||||
.clear = tce_free_pSeries,
|
||||
.get = tce_get_pseries
|
||||
};
|
||||
|
||||
static void pci_dma_bus_setup_pSeries(struct pci_bus *bus)
|
||||
{
|
||||
struct device_node *dn;
|
||||
@@ -627,6 +635,7 @@ static void pci_dma_bus_setup_pSeries(struct pci_bus *bus)
|
||||
pci->phb->node);
|
||||
|
||||
iommu_table_setparms(pci->phb, dn, tbl);
|
||||
tbl->it_ops = &iommu_table_pseries_ops;
|
||||
pci->iommu_table = iommu_init_table(tbl, pci->phb->node);
|
||||
iommu_register_group(tbl, pci_domain_nr(bus), 0);
|
||||
|
||||
@@ -638,6 +647,11 @@ static void pci_dma_bus_setup_pSeries(struct pci_bus *bus)
|
||||
pr_debug("ISA/IDE, window size is 0x%llx\n", pci->phb->dma_window_size);
|
||||
}
|
||||
|
||||
struct iommu_table_ops iommu_table_lpar_multi_ops = {
|
||||
.set = tce_buildmulti_pSeriesLP,
|
||||
.clear = tce_freemulti_pSeriesLP,
|
||||
.get = tce_get_pSeriesLP
|
||||
};
|
||||
|
||||
static void pci_dma_bus_setup_pSeriesLP(struct pci_bus *bus)
|
||||
{
|
||||
@@ -672,6 +686,7 @@ static void pci_dma_bus_setup_pSeriesLP(struct pci_bus *bus)
|
||||
tbl = kzalloc_node(sizeof(struct iommu_table), GFP_KERNEL,
|
||||
ppci->phb->node);
|
||||
iommu_table_setparms_lpar(ppci->phb, pdn, tbl, dma_window);
|
||||
tbl->it_ops = &iommu_table_lpar_multi_ops;
|
||||
ppci->iommu_table = iommu_init_table(tbl, ppci->phb->node);
|
||||
iommu_register_group(tbl, pci_domain_nr(bus), 0);
|
||||
pr_debug(" created table: %p\n", ppci->iommu_table);
|
||||
@@ -699,6 +714,7 @@ static void pci_dma_dev_setup_pSeries(struct pci_dev *dev)
|
||||
tbl = kzalloc_node(sizeof(struct iommu_table), GFP_KERNEL,
|
||||
phb->node);
|
||||
iommu_table_setparms(phb, dn, tbl);
|
||||
tbl->it_ops = &iommu_table_pseries_ops;
|
||||
PCI_DN(dn)->iommu_table = iommu_init_table(tbl, phb->node);
|
||||
iommu_register_group(tbl, pci_domain_nr(phb->bus), 0);
|
||||
set_iommu_table_base(&dev->dev, tbl);
|
||||
@@ -1121,6 +1137,7 @@ static void pci_dma_dev_setup_pSeriesLP(struct pci_dev *dev)
|
||||
tbl = kzalloc_node(sizeof(struct iommu_table), GFP_KERNEL,
|
||||
pci->phb->node);
|
||||
iommu_table_setparms_lpar(pci->phb, pdn, tbl, dma_window);
|
||||
tbl->it_ops = &iommu_table_lpar_multi_ops;
|
||||
pci->iommu_table = iommu_init_table(tbl, pci->phb->node);
|
||||
iommu_register_group(tbl, pci_domain_nr(pci->phb->bus), 0);
|
||||
pr_debug(" created table: %p\n", pci->iommu_table);
|
||||
@@ -1315,22 +1332,11 @@ void iommu_init_early_pSeries(void)
|
||||
return;
|
||||
|
||||
if (firmware_has_feature(FW_FEATURE_LPAR)) {
|
||||
if (firmware_has_feature(FW_FEATURE_MULTITCE)) {
|
||||
ppc_md.tce_build = tce_buildmulti_pSeriesLP;
|
||||
ppc_md.tce_free = tce_freemulti_pSeriesLP;
|
||||
} else {
|
||||
ppc_md.tce_build = tce_build_pSeriesLP;
|
||||
ppc_md.tce_free = tce_free_pSeriesLP;
|
||||
}
|
||||
ppc_md.tce_get = tce_get_pSeriesLP;
|
||||
pseries_pci_controller_ops.dma_bus_setup = pci_dma_bus_setup_pSeriesLP;
|
||||
pseries_pci_controller_ops.dma_dev_setup = pci_dma_dev_setup_pSeriesLP;
|
||||
ppc_md.dma_set_mask = dma_set_mask_pSeriesLP;
|
||||
ppc_md.dma_get_required_mask = dma_get_required_mask_pSeriesLP;
|
||||
} else {
|
||||
ppc_md.tce_build = tce_build_pSeries;
|
||||
ppc_md.tce_free = tce_free_pSeries;
|
||||
ppc_md.tce_get = tce_get_pseries;
|
||||
pseries_pci_controller_ops.dma_bus_setup = pci_dma_bus_setup_pSeries;
|
||||
pseries_pci_controller_ops.dma_dev_setup = pci_dma_dev_setup_pSeries;
|
||||
}
|
||||
@@ -1348,8 +1354,6 @@ static int __init disable_multitce(char *str)
|
||||
firmware_has_feature(FW_FEATURE_LPAR) &&
|
||||
firmware_has_feature(FW_FEATURE_MULTITCE)) {
|
||||
printk(KERN_INFO "Disabling MULTITCE firmware feature\n");
|
||||
ppc_md.tce_build = tce_build_pSeriesLP;
|
||||
ppc_md.tce_free = tce_free_pSeriesLP;
|
||||
powerpc_firmware_features &= ~FW_FEATURE_MULTITCE;
|
||||
}
|
||||
return 1;
|
||||
|
在新工单中引用
屏蔽一个用户