powerpc/iommu: Move tce_xxx callbacks from ppc_md to iommu_table
This adds a iommu_table_ops struct and puts pointer to it into the iommu_table struct. This moves tce_build/tce_free/tce_get/tce_flush callbacks from ppc_md to the new struct where they really belong to. This adds the requirement for @it_ops to be initialized before calling iommu_init_table() to make sure that we do not leave any IOMMU table with iommu_table_ops uninitialized. This is not a parameter of iommu_init_table() though as there will be cases when iommu_init_table() will not be called on TCE tables, for example - VFIO. This does s/tce_build/set/, s/tce_free/clear/ and removes "tce_" redundant prefixes. This removes tce_xxx_rm handlers from ppc_md but does not add them to iommu_table_ops as this will be done later if we decide to support TCE hypercalls in real mode. This removes _vm callbacks as only virtual mode is supported by now so this also removes @rm parameter. For pSeries, this always uses tce_buildmulti_pSeriesLP/ tce_buildmulti_pSeriesLP. This changes multi callback to fall back to tce_build_pSeriesLP/tce_free_pSeriesLP if FW_FEATURE_MULTITCE is not present. The reason for this is we still have to support "multitce=off" boot parameter in disable_multitce() and we do not want to walk through all IOMMU tables in the system and replace "multi" callbacks with single ones. For powernv, this defines _ops per PHB type which are P5IOC2/IODA1/IODA2. This makes the callbacks for them public. Later patches will extend callbacks for IODA1/2. No change in behaviour is expected. Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:

committed by
Michael Ellerman

parent
10b35b2b74
commit
da004c3600
@@ -466,6 +466,11 @@ static inline u32 cell_iommu_get_ioid(struct device_node *np)
|
||||
return *ioid;
|
||||
}
|
||||
|
||||
static struct iommu_table_ops cell_iommu_ops = {
|
||||
.set = tce_build_cell,
|
||||
.clear = tce_free_cell
|
||||
};
|
||||
|
||||
static struct iommu_window * __init
|
||||
cell_iommu_setup_window(struct cbe_iommu *iommu, struct device_node *np,
|
||||
unsigned long offset, unsigned long size,
|
||||
@@ -492,6 +497,7 @@ cell_iommu_setup_window(struct cbe_iommu *iommu, struct device_node *np,
|
||||
window->table.it_offset =
|
||||
(offset >> window->table.it_page_shift) + pte_offset;
|
||||
window->table.it_size = size >> window->table.it_page_shift;
|
||||
window->table.it_ops = &cell_iommu_ops;
|
||||
|
||||
iommu_init_table(&window->table, iommu->nid);
|
||||
|
||||
@@ -1201,8 +1207,6 @@ static int __init cell_iommu_init(void)
|
||||
/* Setup various callbacks */
|
||||
cell_pci_controller_ops.dma_dev_setup = cell_pci_dma_dev_setup;
|
||||
ppc_md.dma_get_required_mask = cell_dma_get_required_mask;
|
||||
ppc_md.tce_build = tce_build_cell;
|
||||
ppc_md.tce_free = tce_free_cell;
|
||||
|
||||
if (!iommu_fixed_disabled && cell_iommu_fixed_mapping_init() == 0)
|
||||
goto bail;
|
||||
|
Reference in New Issue
Block a user