mm: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Link: http://lkml.kernel.org/r/20190122152151.16139-14-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Michal Hocko <mhocko@suse.com> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: David Rientjes <rientjes@google.com> Cc: Laura Abbott <labbott@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

parent
0ee930e6ca
commit
d9f7979c92
@@ -3230,24 +3230,14 @@ static int __init fail_page_alloc_debugfs(void)
|
||||
|
||||
dir = fault_create_debugfs_attr("fail_page_alloc", NULL,
|
||||
&fail_page_alloc.attr);
|
||||
if (IS_ERR(dir))
|
||||
return PTR_ERR(dir);
|
||||
|
||||
if (!debugfs_create_bool("ignore-gfp-wait", mode, dir,
|
||||
&fail_page_alloc.ignore_gfp_reclaim))
|
||||
goto fail;
|
||||
if (!debugfs_create_bool("ignore-gfp-highmem", mode, dir,
|
||||
&fail_page_alloc.ignore_gfp_highmem))
|
||||
goto fail;
|
||||
if (!debugfs_create_u32("min-order", mode, dir,
|
||||
&fail_page_alloc.min_order))
|
||||
goto fail;
|
||||
debugfs_create_bool("ignore-gfp-wait", mode, dir,
|
||||
&fail_page_alloc.ignore_gfp_reclaim);
|
||||
debugfs_create_bool("ignore-gfp-highmem", mode, dir,
|
||||
&fail_page_alloc.ignore_gfp_highmem);
|
||||
debugfs_create_u32("min-order", mode, dir, &fail_page_alloc.min_order);
|
||||
|
||||
return 0;
|
||||
fail:
|
||||
debugfs_remove_recursive(dir);
|
||||
|
||||
return -ENOMEM;
|
||||
}
|
||||
|
||||
late_initcall(fail_page_alloc_debugfs);
|
||||
|
Reference in New Issue
Block a user