scsi: qedf: fix LTO-enabled build
The prototype for qedf_dbg_fops/qedf_debugfs_ops doesn't match the definition, which causes the final link to fail with link-time optimizations: drivers/scsi/qedf/qedf_main.c:34: error: type of 'qedf_dbg_fops' does not match original declaration [-Werror=lto-type-mismatch] extern struct file_operations qedf_dbg_fops; drivers/scsi/qedf/qedf_debugfs.c:443: note: 'qedf_dbg_fops' was previously declared here const struct file_operations qedf_dbg_fops[] = { drivers/scsi/qedf/qedf_main.c:33: error: type of 'qedf_debugfs_ops' does not match original declaration [-Werror=lto-type-mismatch] extern struct qedf_debugfs_ops qedf_debugfs_ops; drivers/scsi/qedf/qedf_debugfs.c:102: note: 'qedf_debugfs_ops' was previously declared here struct qedf_debugfs_ops qedf_debugfs_ops[] = { This corrects the prototype and moves it into a shared header file where it belongs. The file operations can also be marked 'const' like the qedf_debugfs_ops. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Chad Dupuis <chad.dupuis@cavium.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:

کامیت شده توسط
Martin K. Petersen

والد
bc2e1299a8
کامیت
d9ea463a1c
@@ -116,6 +116,14 @@ extern int qedf_create_sysfs_attr(struct Scsi_Host *shost,
|
||||
extern void qedf_remove_sysfs_attr(struct Scsi_Host *shost,
|
||||
struct sysfs_bin_attrs *iter);
|
||||
|
||||
struct qedf_debugfs_ops {
|
||||
char *name;
|
||||
struct qedf_list_of_funcs *qedf_funcs;
|
||||
};
|
||||
|
||||
extern const struct qedf_debugfs_ops qedf_debugfs_ops[];
|
||||
extern const struct file_operations qedf_dbg_fops[];
|
||||
|
||||
#ifdef CONFIG_DEBUG_FS
|
||||
/* DebugFS related code */
|
||||
struct qedf_list_of_funcs {
|
||||
@@ -123,11 +131,6 @@ struct qedf_list_of_funcs {
|
||||
ssize_t (*oper_func)(struct qedf_dbg_ctx *qedf);
|
||||
};
|
||||
|
||||
struct qedf_debugfs_ops {
|
||||
char *name;
|
||||
struct qedf_list_of_funcs *qedf_funcs;
|
||||
};
|
||||
|
||||
#define qedf_dbg_fileops(drv, ops) \
|
||||
{ \
|
||||
.owner = THIS_MODULE, \
|
||||
@@ -147,8 +150,8 @@ struct qedf_debugfs_ops {
|
||||
}
|
||||
|
||||
extern void qedf_dbg_host_init(struct qedf_dbg_ctx *qedf,
|
||||
struct qedf_debugfs_ops *dops,
|
||||
struct file_operations *fops);
|
||||
const struct qedf_debugfs_ops *dops,
|
||||
const struct file_operations *fops);
|
||||
extern void qedf_dbg_host_exit(struct qedf_dbg_ctx *qedf);
|
||||
extern void qedf_dbg_init(char *drv_name);
|
||||
extern void qedf_dbg_exit(void);
|
||||
|
مرجع در شماره جدید
Block a user