drm: add convenience function to create an range property
Creating a range property is a common pattern, so create a convenience function for this and use it where appropriate. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:

committed by
Dave Airlie

parent
4a67d39190
commit
d9bc3c02e3
@@ -2277,10 +2277,8 @@ static bool intel_sdvo_tv_create_property(struct intel_sdvo *intel_sdvo,
|
||||
intel_sdvo_connector->max_##name = data_value[0]; \
|
||||
intel_sdvo_connector->cur_##name = response; \
|
||||
intel_sdvo_connector->name = \
|
||||
drm_property_create(dev, DRM_MODE_PROP_RANGE, #name, 2); \
|
||||
drm_property_create_range(dev, 0, #name, 0, data_value[0]); \
|
||||
if (!intel_sdvo_connector->name) return false; \
|
||||
intel_sdvo_connector->name->values[0] = 0; \
|
||||
intel_sdvo_connector->name->values[1] = data_value[0]; \
|
||||
drm_connector_attach_property(connector, \
|
||||
intel_sdvo_connector->name, \
|
||||
intel_sdvo_connector->cur_##name); \
|
||||
@@ -2314,25 +2312,19 @@ intel_sdvo_create_enhance_property_tv(struct intel_sdvo *intel_sdvo,
|
||||
intel_sdvo_connector->left_margin = data_value[0] - response;
|
||||
intel_sdvo_connector->right_margin = intel_sdvo_connector->left_margin;
|
||||
intel_sdvo_connector->left =
|
||||
drm_property_create(dev, DRM_MODE_PROP_RANGE,
|
||||
"left_margin", 2);
|
||||
drm_property_create_range(dev, 0, "left_margin", 0, data_value[0]);
|
||||
if (!intel_sdvo_connector->left)
|
||||
return false;
|
||||
|
||||
intel_sdvo_connector->left->values[0] = 0;
|
||||
intel_sdvo_connector->left->values[1] = data_value[0];
|
||||
drm_connector_attach_property(connector,
|
||||
intel_sdvo_connector->left,
|
||||
intel_sdvo_connector->left_margin);
|
||||
|
||||
intel_sdvo_connector->right =
|
||||
drm_property_create(dev, DRM_MODE_PROP_RANGE,
|
||||
"right_margin", 2);
|
||||
drm_property_create_range(dev, 0, "right_margin", 0, data_value[0]);
|
||||
if (!intel_sdvo_connector->right)
|
||||
return false;
|
||||
|
||||
intel_sdvo_connector->right->values[0] = 0;
|
||||
intel_sdvo_connector->right->values[1] = data_value[0];
|
||||
drm_connector_attach_property(connector,
|
||||
intel_sdvo_connector->right,
|
||||
intel_sdvo_connector->right_margin);
|
||||
@@ -2356,25 +2348,21 @@ intel_sdvo_create_enhance_property_tv(struct intel_sdvo *intel_sdvo,
|
||||
intel_sdvo_connector->top_margin = data_value[0] - response;
|
||||
intel_sdvo_connector->bottom_margin = intel_sdvo_connector->top_margin;
|
||||
intel_sdvo_connector->top =
|
||||
drm_property_create(dev, DRM_MODE_PROP_RANGE,
|
||||
"top_margin", 2);
|
||||
drm_property_create_range(dev, 0,
|
||||
"top_margin", 0, data_value[0]);
|
||||
if (!intel_sdvo_connector->top)
|
||||
return false;
|
||||
|
||||
intel_sdvo_connector->top->values[0] = 0;
|
||||
intel_sdvo_connector->top->values[1] = data_value[0];
|
||||
drm_connector_attach_property(connector,
|
||||
intel_sdvo_connector->top,
|
||||
intel_sdvo_connector->top_margin);
|
||||
|
||||
intel_sdvo_connector->bottom =
|
||||
drm_property_create(dev, DRM_MODE_PROP_RANGE,
|
||||
"bottom_margin", 2);
|
||||
drm_property_create_range(dev, 0,
|
||||
"bottom_margin", 0, data_value[0]);
|
||||
if (!intel_sdvo_connector->bottom)
|
||||
return false;
|
||||
|
||||
intel_sdvo_connector->bottom->values[0] = 0;
|
||||
intel_sdvo_connector->bottom->values[1] = data_value[0];
|
||||
drm_connector_attach_property(connector,
|
||||
intel_sdvo_connector->bottom,
|
||||
intel_sdvo_connector->bottom_margin);
|
||||
@@ -2403,12 +2391,10 @@ intel_sdvo_create_enhance_property_tv(struct intel_sdvo *intel_sdvo,
|
||||
intel_sdvo_connector->max_dot_crawl = 1;
|
||||
intel_sdvo_connector->cur_dot_crawl = response & 0x1;
|
||||
intel_sdvo_connector->dot_crawl =
|
||||
drm_property_create(dev, DRM_MODE_PROP_RANGE, "dot_crawl", 2);
|
||||
drm_property_create_range(dev, 0, "dot_crawl", 0, 1);
|
||||
if (!intel_sdvo_connector->dot_crawl)
|
||||
return false;
|
||||
|
||||
intel_sdvo_connector->dot_crawl->values[0] = 0;
|
||||
intel_sdvo_connector->dot_crawl->values[1] = 1;
|
||||
drm_connector_attach_property(connector,
|
||||
intel_sdvo_connector->dot_crawl,
|
||||
intel_sdvo_connector->cur_dot_crawl);
|
||||
|
Reference in New Issue
Block a user