[PATCH] klist: fix klist to have the same klist_add semantics as list_head
at the moment, the list_head semantics are list_add(node, head) whereas current klist semantics are klist_add(head, node) This is bound to cause confusion, and since klist is the newcomer, it should follow the list_head semantics. I also added missing include guards to klist.h Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:

committed by
Greg Kroah-Hartman

vanhempi
fef6ec8dd9
commit
d856f1e337
@@ -79,11 +79,11 @@ static void klist_node_init(struct klist * k, struct klist_node * n)
|
||||
|
||||
/**
|
||||
* klist_add_head - Initialize a klist_node and add it to front.
|
||||
* @k: klist it's going on.
|
||||
* @n: node we're adding.
|
||||
* @k: klist it's going on.
|
||||
*/
|
||||
|
||||
void klist_add_head(struct klist * k, struct klist_node * n)
|
||||
void klist_add_head(struct klist_node * n, struct klist * k)
|
||||
{
|
||||
klist_node_init(k, n);
|
||||
add_head(k, n);
|
||||
@@ -94,11 +94,11 @@ EXPORT_SYMBOL_GPL(klist_add_head);
|
||||
|
||||
/**
|
||||
* klist_add_tail - Initialize a klist_node and add it to back.
|
||||
* @k: klist it's going on.
|
||||
* @n: node we're adding.
|
||||
* @k: klist it's going on.
|
||||
*/
|
||||
|
||||
void klist_add_tail(struct klist * k, struct klist_node * n)
|
||||
void klist_add_tail(struct klist_node * n, struct klist * k)
|
||||
{
|
||||
klist_node_init(k, n);
|
||||
add_tail(k, n);
|
||||
|
Viittaa uudesa ongelmassa
Block a user