xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ata: libahci_platform: Add of_node_put() before loop exit

Browse Source 
Each iteration of for_each_child_of_node puts the previous node, but
in the case of a goto from the middle of the loop, there is no put,
thus causing a memory leak. Add an of_node_put before three such goto
statements.
Issue found with Coccinelle.

Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Nishka Dasgupta
2019-08-15 11:30:14 +05:30
committed by Jens Axboe
parent 8454d68563
commit d7f76f36a8
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/ata/libahci_platform.c
View File

@@ -497,6 +497,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
if (of_property_read_u32(child, "reg", &port)) { if (of_property_read_u32(child, "reg", &port)) {
rc = -EINVAL; rc = -EINVAL;
of_node_put(child);
goto err_out; goto err_out;
} }
@@ -514,14 +515,18 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
if (port_dev) { if (port_dev) {
rc = ahci_platform_get_regulator(hpriv, port, rc = ahci_platform_get_regulator(hpriv, port,
&port_dev->dev); &port_dev->dev);
if (rc == -EPROBE_DEFER) if (rc == -EPROBE_DEFER) {
of_node_put(child);
goto err_out; goto err_out;
}
} }
#endif #endif
rc = ahci_platform_get_phy(hpriv, port, dev, child); rc = ahci_platform_get_phy(hpriv, port, dev, child);
if (rc) if (rc) {
of_node_put(child);
goto err_out; goto err_out;
}
enabled_ports++; enabled_ports++;
} }