ocfs2: remove kfree() redundant null checks
smatch analysis indicates a number of redundant NULL checks before calling kfree(), eg: fs/ocfs2/alloc.c:6138 ocfs2_begin_truncate_log_recovery() info: redundant null check on *tl_copy calling kfree() fs/ocfs2/alloc.c:6755 ocfs2_zero_range_for_truncate() info: redundant null check on pages calling kfree() etc.... [akpm@linux-foundation.org: revert dubious change in ocfs2_begin_truncate_log_recovery()] Signed-off-by: Tim Gardner <tim.gardner@canonical.com> Cc: Mark Fasheh <mfasheh@suse.com> Acked-by: Joel Becker <jlbec@evilplan.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Esse commit está contido em:
@@ -1234,11 +1234,8 @@ static void ocfs2_queue_recovery_completion(struct ocfs2_journal *journal,
|
||||
/* Though we wish to avoid it, we are in fact safe in
|
||||
* skipping local alloc cleanup as fsck.ocfs2 is more
|
||||
* than capable of reclaiming unused space. */
|
||||
if (la_dinode)
|
||||
kfree(la_dinode);
|
||||
|
||||
if (tl_dinode)
|
||||
kfree(tl_dinode);
|
||||
kfree(la_dinode);
|
||||
kfree(tl_dinode);
|
||||
|
||||
if (qrec)
|
||||
ocfs2_free_quota_recovery(qrec);
|
||||
@@ -1408,8 +1405,7 @@ bail:
|
||||
|
||||
mutex_unlock(&osb->recovery_lock);
|
||||
|
||||
if (rm_quota)
|
||||
kfree(rm_quota);
|
||||
kfree(rm_quota);
|
||||
|
||||
/* no one is callint kthread_stop() for us so the kthread() api
|
||||
* requires that we call do_exit(). And it isn't exported, but
|
||||
|
Referência em uma nova issue
Block a user