dax: convert devm_create_dax_dev to PTR_ERR

For sub-division support we need access to the dax_dev created by
devm_create_dax_dev().

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Dan Williams
2016-07-19 17:51:40 -07:00
parent 9d2d01a031
commit d76911ee93
3 changed files with 16 additions and 10 deletions

View File

@@ -558,8 +558,8 @@ static void unregister_dax_dev(void *dev)
device_unregister(dev);
}
int devm_create_dax_dev(struct dax_region *dax_region, struct resource *res,
int count)
struct dax_dev *devm_create_dax_dev(struct dax_region *dax_region,
struct resource *res, int count)
{
struct device *parent = dax_region->dev;
struct dax_dev *dax_dev;
@@ -570,7 +570,7 @@ int devm_create_dax_dev(struct dax_region *dax_region, struct resource *res,
dax_dev = kzalloc(sizeof(*dax_dev) + sizeof(*res) * count, GFP_KERNEL);
if (!dax_dev)
return -ENOMEM;
return ERR_PTR(-ENOMEM);
for (i = 0; i < count; i++) {
if (!IS_ALIGNED(res[i].start, dax_region->align)
@@ -632,10 +632,14 @@ int devm_create_dax_dev(struct dax_region *dax_region, struct resource *res,
rc = device_add(dev);
if (rc) {
put_device(dev);
return rc;
return ERR_PTR(rc);
}
return devm_add_action_or_reset(dax_region->dev, unregister_dax_dev, dev);
rc = devm_add_action_or_reset(dax_region->dev, unregister_dax_dev, dev);
if (rc)
return ERR_PTR(rc);
return dax_dev;
err_cdev:
iput(dax_dev->inode);
@@ -646,7 +650,7 @@ int devm_create_dax_dev(struct dax_region *dax_region, struct resource *res,
err_id:
kfree(dax_dev);
return rc;
return ERR_PTR(rc);
}
EXPORT_SYMBOL_GPL(devm_create_dax_dev);