x86/irq: Move IS_ERR_OR_NULL() check into common do_IRQ() code
Both the 64bit and the 32bit handle_irq() implementation check the irq descriptor pointer with IS_ERR_OR_NULL() and return failure. That can be done simpler in the common do_IRQ() code. This reduces the 64bit handle_irq() function to a wrapper around generic_handle_irq_desc(). Invoke it directly from do_IRQ() to spare the extra function call. [ tglx: Got rid of the #ifdef and massaged changelog ] Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lkml.kernel.org/r/2ec758c7-9aaa-73ab-f083-cc44c86aa741@gmail.com
This commit is contained in:

committed by
Thomas Gleixner

parent
e30c44e2e5
commit
d6f83427ff
@@ -243,8 +243,12 @@ __visible unsigned int __irq_entry do_IRQ(struct pt_regs *regs)
|
||||
RCU_LOCKDEP_WARN(!rcu_is_watching(), "IRQ failed to wake up RCU");
|
||||
|
||||
desc = __this_cpu_read(vector_irq[vector]);
|
||||
|
||||
if (!handle_irq(desc, regs)) {
|
||||
if (likely(!IS_ERR_OR_NULL(desc))) {
|
||||
if (IS_ENABLED(CONFIG_X86_32))
|
||||
handle_irq(desc, regs);
|
||||
else
|
||||
generic_handle_irq_desc(desc);
|
||||
} else {
|
||||
ack_APIC_irq();
|
||||
|
||||
if (desc != VECTOR_RETRIGGERED && desc != VECTOR_SHUTDOWN) {
|
||||
|
Reference in New Issue
Block a user