xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ipvs: use explicitly signed chars

Browse Source 
[ Upstream commit 5c26159c97b324dc5174a5713eafb8c855cf8106 ]

The `char` type with no explicit sign is sometimes signed and sometimes
unsigned. This code will break on platforms such as arm, where char is
unsigned. So mark it here as explicitly signed, so that the
todrop_counter decrement and subsequent comparison is correct.

Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Jason A. Donenfeld
2022-10-26 14:32:16 +02:00
committed by Greg Kroah-Hartman
parent b2d7a92aff
commit d69328cdb9
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
net/netfilter/ipvs/ip_vs_conn.c
View File

@@ -1265,8 +1265,8 @@ static inline int todrop_entry(struct ip_vs_conn *cp)
* The drop rate array needs tuning for real environments. * The drop rate array needs tuning for real environments.
* Called from timer bh only => no locking * Called from timer bh only => no locking
*/ */
static const char todrop_rate[9] = {0, 1, 2, 3, 4, 5, 6, 7, 8}; static const signed char todrop_rate[9] = {0, 1, 2, 3, 4, 5, 6, 7, 8};
static char todrop_counter[9] = {0}; static signed char todrop_counter[9] = {0};
int i; int i;
/* if the conn entry hasn't lasted for 60 seconds, don't drop it. /* if the conn entry hasn't lasted for 60 seconds, don't drop it.