net/sched: remove block pointer from common offload structure
Based on feedback from Jiri avoid carrying a pointer to the tcf_block structure in the tc_cls_common_offload structure. Instead store a flag in driver private data which indicates if offloads apply to a shared block at block binding time. Suggested-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com> Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
2e7ae67b5f
commit
d6787147e1
@@ -157,8 +157,7 @@ static int cls_bpf_offload_cmd(struct tcf_proto *tp, struct cls_bpf_prog *prog,
|
||||
skip_sw = prog && tc_skip_sw(prog->gen_flags);
|
||||
obj = prog ?: oldprog;
|
||||
|
||||
tc_cls_common_offload_init(&cls_bpf.common, tp, obj->gen_flags, block,
|
||||
extack);
|
||||
tc_cls_common_offload_init(&cls_bpf.common, tp, obj->gen_flags, extack);
|
||||
cls_bpf.command = TC_CLSBPF_OFFLOAD;
|
||||
cls_bpf.exts = &obj->exts;
|
||||
cls_bpf.prog = prog ? prog->filter : NULL;
|
||||
@@ -227,8 +226,7 @@ static void cls_bpf_offload_update_stats(struct tcf_proto *tp,
|
||||
struct tcf_block *block = tp->chain->block;
|
||||
struct tc_cls_bpf_offload cls_bpf = {};
|
||||
|
||||
tc_cls_common_offload_init(&cls_bpf.common, tp, prog->gen_flags, block,
|
||||
NULL);
|
||||
tc_cls_common_offload_init(&cls_bpf.common, tp, prog->gen_flags, NULL);
|
||||
cls_bpf.command = TC_CLSBPF_STATS;
|
||||
cls_bpf.exts = &prog->exts;
|
||||
cls_bpf.prog = prog->filter;
|
||||
@@ -670,7 +668,7 @@ static int cls_bpf_reoffload(struct tcf_proto *tp, bool add, tc_setup_cb_t *cb,
|
||||
continue;
|
||||
|
||||
tc_cls_common_offload_init(&cls_bpf.common, tp, prog->gen_flags,
|
||||
block, extack);
|
||||
extack);
|
||||
cls_bpf.command = TC_CLSBPF_OFFLOAD;
|
||||
cls_bpf.exts = &prog->exts;
|
||||
cls_bpf.prog = add ? prog->filter : NULL;
|
||||
|
Reference in New Issue
Block a user