[SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}
To clearly state the intent of copying from linear sk_buffs, _offset being a overly long variant but interesting for the sake of saving some bytes. Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:

committed by
David S. Miller

parent
2a123b86e2
commit
d626f62b11
@@ -527,7 +527,7 @@ static int bfusb_send_frame(struct sk_buff *skb)
|
||||
buf[2] = (size == BFUSB_MAX_BLOCK_SIZE) ? 0 : size;
|
||||
|
||||
memcpy(skb_put(nskb, 3), buf, 3);
|
||||
memcpy(skb_put(nskb, size), skb->data + sent, size);
|
||||
skb_copy_from_linear_data_offset(skb, sent, skb_put(nskb, size), size);
|
||||
|
||||
sent += size;
|
||||
count -= size;
|
||||
|
@@ -231,7 +231,7 @@ static void bpa10x_wakeup(struct bpa10x_data *data)
|
||||
cr = (struct usb_ctrlrequest *) urb->setup_packet;
|
||||
cr->wLength = __cpu_to_le16(skb->len);
|
||||
|
||||
memcpy(urb->transfer_buffer, skb->data, skb->len);
|
||||
skb_copy_from_linear_data(skb, urb->transfer_buffer, skb->len);
|
||||
urb->transfer_buffer_length = skb->len;
|
||||
|
||||
err = usb_submit_urb(urb, GFP_ATOMIC);
|
||||
@@ -250,7 +250,7 @@ static void bpa10x_wakeup(struct bpa10x_data *data)
|
||||
skb = skb_dequeue(&data->tx_queue);
|
||||
|
||||
if (skb) {
|
||||
memcpy(urb->transfer_buffer, skb->data, skb->len);
|
||||
skb_copy_from_linear_data(skb, urb->transfer_buffer, skb->len);
|
||||
urb->transfer_buffer_length = skb->len;
|
||||
|
||||
err = usb_submit_urb(urb, GFP_ATOMIC);
|
||||
|
@@ -425,7 +425,7 @@ static int dtl1_hci_send_frame(struct sk_buff *skb)
|
||||
return -ENOMEM;
|
||||
|
||||
skb_reserve(s, NSHL);
|
||||
memcpy(skb_put(s, skb->len), skb->data, skb->len);
|
||||
skb_copy_from_linear_data(skb, skb_put(s, skb->len), skb->len);
|
||||
if (skb->len & 0x0001)
|
||||
*skb_put(s, 1) = 0; /* PAD */
|
||||
|
||||
|
Reference in New Issue
Block a user