networking: make skb_push & __skb_push return void pointers
It seems like a historic accident that these return unsigned char *, and in many places that means casts are required, more often than not. Make these functions return void * and remove all the casts across the tree, adding a (u8 *) cast only where the unsigned char pointer was used directly, all done with the following spatch: @@ expression SKB, LEN; typedef u8; identifier fn = { skb_push, __skb_push, skb_push_rcsum }; @@ - *(fn(SKB, LEN)) + *(u8 *)fn(SKB, LEN) @@ expression E, SKB, LEN; identifier fn = { skb_push, __skb_push, skb_push_rcsum }; type T; @@ - E = ((T *)(fn(SKB, LEN))) + E = fn(SKB, LEN) @@ expression SKB, LEN; identifier fn = { skb_push, __skb_push, skb_push_rcsum }; @@ - fn(SKB, LEN)[0] + *(u8 *)fn(SKB, LEN) Note that the last part there converts from push(...)[0] to the more idiomatic *(u8 *)push(...). Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committato da
David S. Miller

parent
af72868b90
commit
d58ff35122
@@ -626,7 +626,7 @@ static int fcoe_ctlr_encaps(struct fcoe_ctlr *fip, struct fc_lport *lport,
|
||||
fh = (struct fc_frame_header *)skb->data;
|
||||
op = *(u8 *)(fh + 1);
|
||||
dlen = sizeof(struct fip_encaps) + skb->len; /* len before push */
|
||||
cap = (struct fip_encaps_head *)skb_push(skb, sizeof(*cap));
|
||||
cap = skb_push(skb, sizeof(*cap));
|
||||
memset(cap, 0, sizeof(*cap));
|
||||
|
||||
if (lport->point_to_multipoint) {
|
||||
|
Fai riferimento in un nuovo problema
Block a user