ip_vti/ip6_vti: Preserve skb->mark after rcv_cb call
The vti6_rcv_cb and vti_rcv_cb calls were leaving the skb->mark modified after completing the function. This resulted in the original skb->mark value being lost. Since we only need skb->mark to be set for xfrm_policy_check we can pull the assignment into the rcv_cb calls and then just restore the original mark after xfrm_policy_check has been completed. Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
此提交包含在:
@@ -322,7 +322,6 @@ static int vti6_rcv(struct sk_buff *skb)
|
||||
}
|
||||
|
||||
XFRM_TUNNEL_SKB_CB(skb)->tunnel.ip6 = t;
|
||||
skb->mark = be32_to_cpu(t->parms.i_key);
|
||||
|
||||
rcu_read_unlock();
|
||||
|
||||
@@ -342,6 +341,8 @@ static int vti6_rcv_cb(struct sk_buff *skb, int err)
|
||||
struct pcpu_sw_netstats *tstats;
|
||||
struct xfrm_state *x;
|
||||
struct ip6_tnl *t = XFRM_TUNNEL_SKB_CB(skb)->tunnel.ip6;
|
||||
u32 orig_mark = skb->mark;
|
||||
int ret;
|
||||
|
||||
if (!t)
|
||||
return 1;
|
||||
@@ -358,7 +359,11 @@ static int vti6_rcv_cb(struct sk_buff *skb, int err)
|
||||
x = xfrm_input_state(skb);
|
||||
family = x->inner_mode->afinfo->family;
|
||||
|
||||
if (!xfrm_policy_check(NULL, XFRM_POLICY_IN, skb, family))
|
||||
skb->mark = be32_to_cpu(t->parms.i_key);
|
||||
ret = xfrm_policy_check(NULL, XFRM_POLICY_IN, skb, family);
|
||||
skb->mark = orig_mark;
|
||||
|
||||
if (!ret)
|
||||
return -EPERM;
|
||||
|
||||
skb_scrub_packet(skb, !net_eq(t->net, dev_net(skb->dev)));
|
||||
|
新增問題並參考
封鎖使用者