[PATCH] Common compat_sys_sysinfo
I noticed that almost all architectures implemented exactly the same sys32_sysinfo... except parisc, where a bug was to be found in handling of the uptime. So let's remove a whole whack of code for fun and profit. Cribbed compat_sys_sysinfo from x86_64's implementation, since I figured it would be the best tested. This patch incorporates Arnd's suggestion of not using set_fs/get_fs, but instead extracting out the common code from sys_sysinfo. Cc: Christoph Hellwig <hch@infradead.org> Cc: <linux-arch@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:

committed by
Linus Torvalds

szülő
72fd4a35a8
commit
d4d23add3a
@@ -198,73 +198,6 @@ static inline long put_tv32(struct compat_timeval __user *o, struct timeval *i)
|
||||
__put_user(i->tv_usec, &o->tv_usec)));
|
||||
}
|
||||
|
||||
struct sysinfo32 {
|
||||
s32 uptime;
|
||||
u32 loads[3];
|
||||
u32 totalram;
|
||||
u32 freeram;
|
||||
u32 sharedram;
|
||||
u32 bufferram;
|
||||
u32 totalswap;
|
||||
u32 freeswap;
|
||||
unsigned short procs;
|
||||
unsigned short pad;
|
||||
u32 totalhigh;
|
||||
u32 freehigh;
|
||||
u32 mem_unit;
|
||||
char _f[20-2*sizeof(int)-sizeof(int)];
|
||||
};
|
||||
|
||||
asmlinkage long compat_sys_sysinfo(struct sysinfo32 __user *info)
|
||||
{
|
||||
struct sysinfo s;
|
||||
int ret, err;
|
||||
int bitcount=0;
|
||||
mm_segment_t old_fs = get_fs ();
|
||||
|
||||
/* The __user cast is valid due to set_fs() */
|
||||
set_fs (KERNEL_DS);
|
||||
ret = sys_sysinfo((struct sysinfo __user *)&s);
|
||||
set_fs (old_fs);
|
||||
|
||||
/* Check to see if any memory value is too large for 32-bit and
|
||||
* scale down if needed.
|
||||
*/
|
||||
if ((s.totalram >> 32) || (s.totalswap >> 32)) {
|
||||
while (s.mem_unit < PAGE_SIZE) {
|
||||
s.mem_unit <<= 1;
|
||||
bitcount++;
|
||||
}
|
||||
s.totalram >>=bitcount;
|
||||
s.freeram >>= bitcount;
|
||||
s.sharedram >>= bitcount;
|
||||
s.bufferram >>= bitcount;
|
||||
s.totalswap >>= bitcount;
|
||||
s.freeswap >>= bitcount;
|
||||
s.totalhigh >>= bitcount;
|
||||
s.freehigh >>= bitcount;
|
||||
}
|
||||
|
||||
err = put_user (s.uptime, &info->uptime);
|
||||
err |= __put_user (s.loads[0], &info->loads[0]);
|
||||
err |= __put_user (s.loads[1], &info->loads[1]);
|
||||
err |= __put_user (s.loads[2], &info->loads[2]);
|
||||
err |= __put_user (s.totalram, &info->totalram);
|
||||
err |= __put_user (s.freeram, &info->freeram);
|
||||
err |= __put_user (s.sharedram, &info->sharedram);
|
||||
err |= __put_user (s.bufferram, &info->bufferram);
|
||||
err |= __put_user (s.totalswap, &info->totalswap);
|
||||
err |= __put_user (s.freeswap, &info->freeswap);
|
||||
err |= __put_user (s.procs, &info->procs);
|
||||
err |= __put_user (s.totalhigh, &info->totalhigh);
|
||||
err |= __put_user (s.freehigh, &info->freehigh);
|
||||
err |= __put_user (s.mem_unit, &info->mem_unit);
|
||||
if (err)
|
||||
return -EFAULT;
|
||||
|
||||
return ret;
|
||||
}
|
||||
|
||||
|
||||
|
||||
|
||||
|
Reference in New Issue
Block a user