[PATCH] uml: add locking to network transport registration
The registration of host network transports needed some locking. The transport list itself is locked, but calls to the registration routines are not. This is compensated for by checking that a transport structure is not yet on any list. I also took the opportunity to const all fields in the transport structure except the list, which obviously can be modified. Signed-off-by: Jeff Dike <jdike@addtoit.com> Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Šī revīzija ir iekļauta:

revīziju iesūtīja
Linus Torvalds

vecāks
190c3e4563
revīzija
d3b7f69de2
@@ -498,10 +498,8 @@ struct eth_init {
|
||||
int index;
|
||||
};
|
||||
|
||||
/* Filled in at boot time. Will need locking if the transports become
|
||||
* modular.
|
||||
*/
|
||||
struct list_head transports = LIST_HEAD_INIT(transports);
|
||||
static DEFINE_SPINLOCK(transports_lock);
|
||||
static LIST_HEAD(transports);
|
||||
|
||||
/* Filled in during early boot */
|
||||
struct list_head eth_cmd_line = LIST_HEAD_INIT(eth_cmd_line);
|
||||
@@ -540,7 +538,10 @@ void register_transport(struct transport *new)
|
||||
char *mac = NULL;
|
||||
int match;
|
||||
|
||||
spin_lock(&transports_lock);
|
||||
BUG_ON(!list_empty(&new->list));
|
||||
list_add(&new->list, &transports);
|
||||
spin_unlock(&transports_lock);
|
||||
|
||||
list_for_each_safe(ele, next, ð_cmd_line){
|
||||
eth = list_entry(ele, struct eth_init, list);
|
||||
|
Atsaukties uz šo jaunā problēmā
Block a user