snd/hda, drm/i915: Track the display_power_status using a cookie
drm/i915 is tracking all wakeref owners with a cookie in order to identify leaks. To that end, each rpm acquisition ops->get_power is assigned a cookie which should be passed to ops->put_power to signify its release (and removal from the list of wakeref owners). As snd/hda is already using a bool to track current status of display_power extending that to an unsigned long to hold the boolean cookie is a trivial extension, and will quell all doubt that snd/hda is the cause of the device runtime pm leaks. v2: Keep using the power abstraction for local wakeref tracking. v3: BUILD_BUG_ON impedance mismatch Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Takashi Iwai <tiwai@suse.de> Cc: Jani Nikula <jani.nikula@intel.com> Acked-by: Takashi Iwai <tiwai@suse.de> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190213152109.16997-1-chris@chris-wilson.co.uk
这个提交包含在:
@@ -79,17 +79,23 @@ void snd_hdac_display_power(struct hdac_bus *bus, unsigned int idx, bool enable)
|
||||
|
||||
if (bus->display_power_status) {
|
||||
if (!bus->display_power_active) {
|
||||
unsigned long cookie = -1;
|
||||
|
||||
if (acomp->ops->get_power)
|
||||
acomp->ops->get_power(acomp->dev);
|
||||
cookie = acomp->ops->get_power(acomp->dev);
|
||||
|
||||
snd_hdac_set_codec_wakeup(bus, true);
|
||||
snd_hdac_set_codec_wakeup(bus, false);
|
||||
bus->display_power_active = true;
|
||||
bus->display_power_active = cookie;
|
||||
}
|
||||
} else {
|
||||
if (bus->display_power_active) {
|
||||
unsigned long cookie = bus->display_power_active;
|
||||
|
||||
if (acomp->ops->put_power)
|
||||
acomp->ops->put_power(acomp->dev);
|
||||
bus->display_power_active = false;
|
||||
acomp->ops->put_power(acomp->dev, cookie);
|
||||
|
||||
bus->display_power_active = 0;
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -325,9 +331,9 @@ int snd_hdac_acomp_exit(struct hdac_bus *bus)
|
||||
return 0;
|
||||
|
||||
if (WARN_ON(bus->display_power_active) && acomp->ops)
|
||||
acomp->ops->put_power(acomp->dev);
|
||||
acomp->ops->put_power(acomp->dev, bus->display_power_active);
|
||||
|
||||
bus->display_power_active = false;
|
||||
bus->display_power_active = 0;
|
||||
bus->display_power_status = 0;
|
||||
|
||||
component_master_del(dev, &hdac_component_master_ops);
|
||||
|
在新工单中引用
屏蔽一个用户