net: Remove dev_err() usage after platform_get_irq()
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Cc: "David S. Miller" <davem@davemloft.net> Cc: Kalle Valo <kvalo@codeaurora.org> Cc: Saeed Mahameed <saeedm@mellanox.com> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Cc: Felix Fietkau <nbd@nbd.name> Cc: Lorenzo Bianconi <lorenzo@kernel.org> Cc: netdev@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
2d73a6c38d
commit
d1a55841ab
@@ -759,7 +759,6 @@ static int rcar_can_probe(struct platform_device *pdev)
|
||||
|
||||
irq = platform_get_irq(pdev, 0);
|
||||
if (irq < 0) {
|
||||
dev_err(&pdev->dev, "No IRQ resource\n");
|
||||
err = irq;
|
||||
goto fail;
|
||||
}
|
||||
|
@@ -1651,14 +1651,12 @@ static int rcar_canfd_probe(struct platform_device *pdev)
|
||||
|
||||
ch_irq = platform_get_irq(pdev, 0);
|
||||
if (ch_irq < 0) {
|
||||
dev_err(&pdev->dev, "no Channel IRQ resource\n");
|
||||
err = ch_irq;
|
||||
goto fail_dev;
|
||||
}
|
||||
|
||||
g_irq = platform_get_irq(pdev, 1);
|
||||
if (g_irq < 0) {
|
||||
dev_err(&pdev->dev, "no Global IRQ resource\n");
|
||||
err = g_irq;
|
||||
goto fail_dev;
|
||||
}
|
||||
|
Reference in New Issue
Block a user