memory: tegra: Delete unneeded of_node_put()
for_each_child_of_node() performs an of_node_put() on each iteration, so putting an of_node_put() before a continue results in a double put. The semantic match that finds this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ expression root,e; local idexpression child; iterator name for_each_child_of_node; @@ for_each_child_of_node(root, child) { ... when != of_node_get(child) * of_node_put(child); ... * continue; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Thierry Reding <treding@nvidia.com>
Dieser Commit ist enthalten in:

committet von
Thierry Reding

Ursprung
aafb197f75
Commit
d1122e4b76
@@ -997,10 +997,8 @@ tegra_emc_find_node_by_ram_code(struct device_node *node, u32 ram_code)
|
||||
u32 value;
|
||||
|
||||
err = of_property_read_u32(np, "nvidia,ram-code", &value);
|
||||
if (err || (value != ram_code)) {
|
||||
of_node_put(np);
|
||||
if (err || (value != ram_code))
|
||||
continue;
|
||||
}
|
||||
|
||||
return np;
|
||||
}
|
||||
|
In neuem Issue referenzieren
Einen Benutzer sperren