nfsd4: teach encoders to handle reserve_space failures
We've tried to prevent running out of space with COMPOUND_SLACK_SPACE and special checking in those operations (getattr) whose result can vary enormously. However: - COMPOUND_SLACK_SPACE may be difficult to maintain as we add more protocol. - BUG_ON or page faulting on failure seems overly fragile. - Especially in the 4.1 case, we prefer not to fail compounds just because the returned result came *close* to session limits. (Though perfect enforcement here may be difficult.) - I'd prefer encoding to be uniform for all encoders instead of having special exceptions for encoders containing, for example, attributes. Signed-off-by: J. Bruce Fields <bfields@redhat.com>
This commit is contained in:
@@ -1400,7 +1400,7 @@ encode_op:
|
||||
}
|
||||
if (op->status == nfserr_replay_me) {
|
||||
op->replay = &cstate->replay_owner->so_replay;
|
||||
nfsd4_encode_replay(resp, op);
|
||||
nfsd4_encode_replay(&resp->xdr, op);
|
||||
status = op->status = op->replay->rp_status;
|
||||
} else {
|
||||
nfsd4_encode_operation(resp, op);
|
||||
|
Reference in New Issue
Block a user