xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

powerpc/opal: Add inline function to get rc from an ASYNC_COMP opal_msg

Browse Source 
An opal_msg of type OPAL_MSG_ASYNC_COMP contains the return code in the
params[1] struct member. However this isn't intuitive or obvious when
reading the code and requires that a user look at the skiboot
documentation or opal-api.h to verify this.

Add an inline function to get the return code from an opal_msg and update
call sites accordingly.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Suraj Jitindar Singh
2016-06-29 13:38:38 +10:00
committed by Michael Ellerman
parent 1ae88fd54c
commit d0226d315d
7 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/rtc/rtc-opal.c
View File

@@ -134,7 +134,7 @@ static int opal_get_tpo_time(struct device *dev, struct rtc_wkalrm *alarm)
goto exit;
}
rc = be64_to_cpu(msg.params[1]);
rc = opal_get_async_rc(msg);
if (rc != OPAL_SUCCESS) {
rc = -EIO;
goto exit;
@@ -181,7 +181,7 @@ static int opal_set_tpo_time(struct device *dev, struct rtc_wkalrm *alarm)
goto exit;
}
rc = be64_to_cpu(msg.params[1]);
rc = opal_get_async_rc(msg);
if (rc != OPAL_SUCCESS)
rc = -EIO;