xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: reintroduce missing rcu_assign_pointer() calls

Browse Source 
commit a9b3cd7f32 (rcu: convert uses of rcu_assign_pointer(x, NULL) to
RCU_INIT_POINTER) did a lot of incorrect changes, since it did a
complete conversion of rcu_assign_pointer(x, y) to RCU_INIT_POINTER(x,
y).

We miss needed barriers, even on x86, when y is not NULL.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Stephen Hemminger <shemminger@vyatta.com>
CC: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Dumazet
2012-01-12 04:41:32 +00:00
committed by David S. Miller
parent 9ee6045f09
commit cf778b00e9
32 changed files with 61 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
net/core/net-sysfs.c
View File

@@ -1177,9 +1177,9 @@ static ssize_t store_xps_map(struct netdev_queue *queue,
nonempty = 1;
}
if (nonempty)
RCU_INIT_POINTER(dev->xps_maps, new_dev_maps);
else {
if (nonempty) {
rcu_assign_pointer(dev->xps_maps, new_dev_maps);
} else {
kfree(new_dev_maps);
RCU_INIT_POINTER(dev->xps_maps, NULL);
}

2
net/core/netpoll.c
View File

@@ -765,7 +765,7 @@ int __netpoll_setup(struct netpoll *np)
}
/* last thing to do is link it to the net device structure */
RCU_INIT_POINTER(ndev->npinfo, npinfo);
rcu_assign_pointer(ndev->npinfo, npinfo);
return 0;