cpufreq: change '.set_boost' to act on one policy
Macro 'for_each_active_policy()' is defined internally. To avoid some cpufreq driver needing this macro to iterate over all the policies in '.set_boost' callback, we redefine '.set_boost' to act on only one policy and pass the policy as an argument. 'cpufreq_boost_trigger_state()' iterates over all the policies to set boost for the system. This is preparation for adding SW BOOST support for CPPC. To protect Boost enable/disable by sysfs from CPU online/offline, add 'cpu_hotplug_lock' before calling '.set_boost' for each CPU. Also move the lock from 'set_boost()' to 'store_cpb()' in acpi_cpufreq. Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> Suggested-by: Viresh Kumar <viresh.kumar@linaro.org> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> [ rjw: Subject & changelog ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:

committed by
Rafael J. Wysocki

parent
73e5f9c0d3
commit
cf6fada715
@@ -126,12 +126,12 @@ static void boost_set_msr_each(void *p_en)
|
||||
boost_set_msr(enable);
|
||||
}
|
||||
|
||||
static int set_boost(int val)
|
||||
static int set_boost(struct cpufreq_policy *policy, int val)
|
||||
{
|
||||
get_online_cpus();
|
||||
on_each_cpu(boost_set_msr_each, (void *)(long)val, 1);
|
||||
put_online_cpus();
|
||||
pr_debug("Core Boosting %sabled.\n", val ? "en" : "dis");
|
||||
on_each_cpu_mask(policy->cpus, boost_set_msr_each,
|
||||
(void *)(long)val, 1);
|
||||
pr_debug("CPU %*pbl: Core Boosting %sabled.\n",
|
||||
cpumask_pr_args(policy->cpus), val ? "en" : "dis");
|
||||
|
||||
return 0;
|
||||
}
|
||||
@@ -162,7 +162,9 @@ static ssize_t store_cpb(struct cpufreq_policy *policy, const char *buf,
|
||||
if (ret || val > 1)
|
||||
return -EINVAL;
|
||||
|
||||
set_boost(val);
|
||||
get_online_cpus();
|
||||
set_boost(policy, val);
|
||||
put_online_cpus();
|
||||
|
||||
return count;
|
||||
}
|
||||
|
Reference in New Issue
Block a user