usb: dwc2: host: Rename some fields in struct dwc2_qh
This no-op change just does some renames to simplify a future patch. 1. The "interval" field is renamed to "host_interval" to make it more obvious that this interval may be 8 times the interval that the device sees (if we're doing split transactions). A future patch will also add the "device_interval" field. 2. The "usecs" field is renamed to "host_us" again to make it more obvious that this is the time for the transaction as seen by the host. For split transactions the device may see a much longer transaction time. A future patch will also add "device_us". 3. The "sched_frame" field is renamed to "next_active_frame". The name "sched_frame" kept confusing me because it felt like something more permament (the QH's reservation or something). The name "next_active_frame" makes it more obvious that this field is constantly changing. Acked-by: John Youn <johnyoun@synopsys.com> Signed-off-by: Douglas Anderson <dianders@chromium.org> Tested-by: Heiko Stuebner <heiko@sntech.de> Tested-by: Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by: Felipe Balbi <balbi@kernel.org>
This commit is contained in:

gecommit door
Felipe Balbi

bovenliggende
4e50e0110c
commit
ced9eee122
@@ -81,7 +81,7 @@ static u16 dwc2_max_desc_num(struct dwc2_qh *qh)
|
||||
static u16 dwc2_frame_incr_val(struct dwc2_qh *qh)
|
||||
{
|
||||
return qh->dev_speed == USB_SPEED_HIGH ?
|
||||
(qh->interval + 8 - 1) / 8 : qh->interval;
|
||||
(qh->host_interval + 8 - 1) / 8 : qh->host_interval;
|
||||
}
|
||||
|
||||
static int dwc2_desc_list_alloc(struct dwc2_hsotg *hsotg, struct dwc2_qh *qh,
|
||||
@@ -252,7 +252,7 @@ static void dwc2_update_frame_list(struct dwc2_hsotg *hsotg, struct dwc2_qh *qh,
|
||||
chan = qh->channel;
|
||||
inc = dwc2_frame_incr_val(qh);
|
||||
if (qh->ep_type == USB_ENDPOINT_XFER_ISOC)
|
||||
i = dwc2_frame_list_idx(qh->sched_frame);
|
||||
i = dwc2_frame_list_idx(qh->next_active_frame);
|
||||
else
|
||||
i = 0;
|
||||
|
||||
@@ -278,13 +278,13 @@ static void dwc2_update_frame_list(struct dwc2_hsotg *hsotg, struct dwc2_qh *qh,
|
||||
return;
|
||||
|
||||
chan->schinfo = 0;
|
||||
if (chan->speed == USB_SPEED_HIGH && qh->interval) {
|
||||
if (chan->speed == USB_SPEED_HIGH && qh->host_interval) {
|
||||
j = 1;
|
||||
/* TODO - check this */
|
||||
inc = (8 + qh->interval - 1) / qh->interval;
|
||||
inc = (8 + qh->host_interval - 1) / qh->host_interval;
|
||||
for (i = 0; i < inc; i++) {
|
||||
chan->schinfo |= j;
|
||||
j = j << qh->interval;
|
||||
j = j << qh->host_interval;
|
||||
}
|
||||
} else {
|
||||
chan->schinfo = 0xff;
|
||||
@@ -431,7 +431,10 @@ static u16 dwc2_calc_starting_frame(struct dwc2_hsotg *hsotg,
|
||||
|
||||
hsotg->frame_number = dwc2_hcd_get_frame_number(hsotg);
|
||||
|
||||
/* sched_frame is always frame number (not uFrame) both in FS and HS! */
|
||||
/*
|
||||
* next_active_frame is always frame number (not uFrame) both in FS
|
||||
* and HS!
|
||||
*/
|
||||
|
||||
/*
|
||||
* skip_frames is used to limit activated descriptors number
|
||||
@@ -514,13 +517,13 @@ static u16 dwc2_recalc_initial_desc_idx(struct dwc2_hsotg *hsotg,
|
||||
*/
|
||||
fr_idx_tmp = dwc2_frame_list_idx(frame);
|
||||
fr_idx = (FRLISTEN_64_SIZE +
|
||||
dwc2_frame_list_idx(qh->sched_frame) - fr_idx_tmp)
|
||||
% dwc2_frame_incr_val(qh);
|
||||
dwc2_frame_list_idx(qh->next_active_frame) -
|
||||
fr_idx_tmp) % dwc2_frame_incr_val(qh);
|
||||
fr_idx = (fr_idx + fr_idx_tmp) % FRLISTEN_64_SIZE;
|
||||
} else {
|
||||
qh->sched_frame = dwc2_calc_starting_frame(hsotg, qh,
|
||||
qh->next_active_frame = dwc2_calc_starting_frame(hsotg, qh,
|
||||
&skip_frames);
|
||||
fr_idx = dwc2_frame_list_idx(qh->sched_frame);
|
||||
fr_idx = dwc2_frame_list_idx(qh->next_active_frame);
|
||||
}
|
||||
|
||||
qh->td_first = qh->td_last = dwc2_frame_to_desc_idx(qh, fr_idx);
|
||||
@@ -583,7 +586,7 @@ static void dwc2_init_isoc_dma_desc(struct dwc2_hsotg *hsotg,
|
||||
u16 next_idx;
|
||||
|
||||
idx = qh->td_last;
|
||||
inc = qh->interval;
|
||||
inc = qh->host_interval;
|
||||
hsotg->frame_number = dwc2_hcd_get_frame_number(hsotg);
|
||||
cur_idx = dwc2_frame_list_idx(hsotg->frame_number);
|
||||
next_idx = dwc2_desclist_idx_inc(qh->td_last, inc, qh->dev_speed);
|
||||
@@ -605,11 +608,11 @@ static void dwc2_init_isoc_dma_desc(struct dwc2_hsotg *hsotg,
|
||||
}
|
||||
}
|
||||
|
||||
if (qh->interval) {
|
||||
ntd_max = (dwc2_max_desc_num(qh) + qh->interval - 1) /
|
||||
qh->interval;
|
||||
if (qh->host_interval) {
|
||||
ntd_max = (dwc2_max_desc_num(qh) + qh->host_interval - 1) /
|
||||
qh->host_interval;
|
||||
if (skip_frames && !qh->channel)
|
||||
ntd_max -= skip_frames / qh->interval;
|
||||
ntd_max -= skip_frames / qh->host_interval;
|
||||
}
|
||||
|
||||
max_xfer_size = qh->dev_speed == USB_SPEED_HIGH ?
|
||||
@@ -1029,7 +1032,7 @@ static void dwc2_complete_isoc_xfer_ddma(struct dwc2_hsotg *hsotg,
|
||||
idx);
|
||||
if (rc < 0)
|
||||
return;
|
||||
idx = dwc2_desclist_idx_inc(idx, qh->interval,
|
||||
idx = dwc2_desclist_idx_inc(idx, qh->host_interval,
|
||||
chan->speed);
|
||||
if (!rc)
|
||||
continue;
|
||||
@@ -1039,7 +1042,7 @@ static void dwc2_complete_isoc_xfer_ddma(struct dwc2_hsotg *hsotg,
|
||||
|
||||
/* rc == DWC2_CMPL_STOP */
|
||||
|
||||
if (qh->interval >= 32)
|
||||
if (qh->host_interval >= 32)
|
||||
goto stop_scan;
|
||||
|
||||
qh->td_first = idx;
|
||||
|
Verwijs in nieuw issue
Block a user