xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ipv6: fix another slab-out-of-bounds in fib6_nh_flush_exceptions

Browse Source 
[ Upstream commit 8fb4792f091e608a0a1d353dfdf07ef55a719db5 ]

While running the self-tests on a KASAN enabled kernel, I observed a
slab-out-of-bounds splat very similar to the one reported in
commit 821bbf79fe46 ("ipv6: Fix KASAN: slab-out-of-bounds Read in
 fib6_nh_flush_exceptions").

We additionally need to take care of fib6_metrics initialization
failure when the caller provides an nh.

The fix is similar, explicitly free the route instead of calling
fib6_info_release on a half-initialized object.

Fixes: f88d8ea67f ("ipv6: Plumb support for nexthop object in a fib6_info")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Paolo Abeni
2021-07-20 15:08:40 +02:00
committed by Greg Kroah-Hartman
parent 071729150b
commit ce8fafb680
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
net/ipv6/route.c
View File

@@ -3640,7 +3640,7 @@ static struct fib6_info *ip6_route_info_create(struct fib6_config *cfg,
err = PTR_ERR(rt->fib6_metrics); err = PTR_ERR(rt->fib6_metrics);
/* Do not leave garbage there. */ /* Do not leave garbage there. */
rt->fib6_metrics = (struct dst_metrics *)&dst_default_metrics; rt->fib6_metrics = (struct dst_metrics *)&dst_default_metrics;
goto out; goto out_free;
} }
if (cfg->fc_flags & RTF_ADDRCONF) if (cfg->fc_flags & RTF_ADDRCONF)