perf record: Add an option to take an AUX snapshot on exit
It is sometimes useful to generate a snapshot when perf record exits; I've been using a wrapper script around the workload that would do a killall -USR2 perf when the workload exits. This patch makes it easier and also works when perf record is attached to a pre-existing task. A new snapshot option 'e' can be specified in -S to enable this behavior: root@elsewhere:~# perf record -e intel_pt// -Se sleep 1 [ perf record: Woken up 2 times to write data ] [ perf record: Captured and wrote 0.085 MB perf.data ] Co-developed-by: Adrian Hunter <adrian.hunter@intel.com> Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/20190806144101.62892-1-alexander.shishkin@linux.intel.com [ Fixed up !HAVE_AUXTRACE_SUPPORT build in builtin-record.c, adding 2 missing __maybe_unused ] Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:

committed by
Arnaldo Carvalho de Melo

parent
73e5de70dc
commit
ce7b0e426e
@@ -539,9 +539,9 @@ int auxtrace_record__snapshot_start(struct auxtrace_record *itr)
|
||||
return 0;
|
||||
}
|
||||
|
||||
int auxtrace_record__snapshot_finish(struct auxtrace_record *itr)
|
||||
int auxtrace_record__snapshot_finish(struct auxtrace_record *itr, bool on_exit)
|
||||
{
|
||||
if (itr && itr->snapshot_finish)
|
||||
if (!on_exit && itr && itr->snapshot_finish)
|
||||
return itr->snapshot_finish(itr);
|
||||
return 0;
|
||||
}
|
||||
@@ -577,6 +577,16 @@ int auxtrace_parse_snapshot_options(struct auxtrace_record *itr,
|
||||
if (!str)
|
||||
return 0;
|
||||
|
||||
/* PMU-agnostic options */
|
||||
switch (*str) {
|
||||
case 'e':
|
||||
opts->auxtrace_snapshot_on_exit = true;
|
||||
str++;
|
||||
break;
|
||||
default:
|
||||
break;
|
||||
}
|
||||
|
||||
if (itr)
|
||||
return itr->parse_snapshot_options(itr, opts, str);
|
||||
|
||||
|
@@ -499,7 +499,7 @@ int auxtrace_record__info_fill(struct auxtrace_record *itr,
|
||||
size_t priv_size);
|
||||
void auxtrace_record__free(struct auxtrace_record *itr);
|
||||
int auxtrace_record__snapshot_start(struct auxtrace_record *itr);
|
||||
int auxtrace_record__snapshot_finish(struct auxtrace_record *itr);
|
||||
int auxtrace_record__snapshot_finish(struct auxtrace_record *itr, bool on_exit);
|
||||
int auxtrace_record__find_snapshot(struct auxtrace_record *itr, int idx,
|
||||
struct auxtrace_mmap *mm,
|
||||
unsigned char *data, u64 *head, u64 *old);
|
||||
|
Reference in New Issue
Block a user