ovl: fix relatime for directories
Need to treat non-regular overlayfs files the same as regular files when checking for an atime update. Add a d_real() flag to make it return the upper dentry for all file types. Reported-by: "zhangyi (F)" <yi.zhang@huawei.com> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
This commit is contained in:
21
fs/inode.c
21
fs/inode.c
@@ -1569,11 +1569,24 @@ EXPORT_SYMBOL(bmap);
|
||||
static void update_ovl_inode_times(struct dentry *dentry, struct inode *inode,
|
||||
bool rcu)
|
||||
{
|
||||
if (!rcu) {
|
||||
struct inode *realinode = d_real_inode(dentry);
|
||||
struct dentry *upperdentry;
|
||||
|
||||
if (unlikely(inode != realinode) &&
|
||||
(!timespec_equal(&inode->i_mtime, &realinode->i_mtime) ||
|
||||
/*
|
||||
* Nothing to do if in rcu or if non-overlayfs
|
||||
*/
|
||||
if (rcu || likely(!(dentry->d_flags & DCACHE_OP_REAL)))
|
||||
return;
|
||||
|
||||
upperdentry = d_real(dentry, NULL, 0, D_REAL_UPPER);
|
||||
|
||||
/*
|
||||
* If file is on lower then we can't update atime, so no worries about
|
||||
* stale mtime/ctime.
|
||||
*/
|
||||
if (upperdentry) {
|
||||
struct inode *realinode = d_inode(upperdentry);
|
||||
|
||||
if ((!timespec_equal(&inode->i_mtime, &realinode->i_mtime) ||
|
||||
!timespec_equal(&inode->i_ctime, &realinode->i_ctime))) {
|
||||
inode->i_mtime = realinode->i_mtime;
|
||||
inode->i_ctime = realinode->i_ctime;
|
||||
|
Reference in New Issue
Block a user