xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

brcmfmac: check return for ARP ip setting iovar

Browse Source 
The return value of iovar set function should be saved and checked.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Hante Meuleman <meuleman@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
Franky Lin
2016-02-17 11:26:56 +01:00
committed by Kalle Valo
parent 52f22fb217
commit cd2bc19c61
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
View File

@@ -1039,16 +1039,16 @@ static int brcmf_inetaddr_changed(struct notifier_block *nb,
return NOTIFY_OK; return NOTIFY_OK;
} }
for (i = 0; i < ARPOL_MAX_ENTRIES; i++) { for (i = 0; i < ARPOL_MAX_ENTRIES; i++) {
if (addr_table[i] != 0) { if (addr_table[i] == 0)
brcmf_fil_iovar_data_set(ifp, continue;
"arp_hostip", &addr_table[i], ret = brcmf_fil_iovar_data_set(ifp, "arp_hostip",
&addr_table[i],
sizeof(addr_table[i])); sizeof(addr_table[i]));
if (ret) if (ret)
brcmf_err("add arp ip err %d\n", brcmf_err("add arp ip err %d\n",
ret); ret);
} }
} }
}
break; break;
default: default:
break; break;