xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bluetooth: L2CAP: Fix invalid access on ECRED Connection response

Browse Source 
[ Upstream commit de895b43932cb47e69480540be7eca289af24f23 ]

The use of l2cap_chan_del is not safe under a loop using
list_for_each_entry.

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Luiz Augusto von Dentz
2021-05-19 13:41:51 -07:00
committed by Greg Kroah-Hartman
parent 79a3130864
commit cc49ab24ec
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
net/bluetooth/l2cap_core.c
View File

@@ -6055,7 +6055,7 @@ static inline int l2cap_ecred_conn_rsp(struct l2cap_conn *conn,
struct l2cap_ecred_conn_rsp *rsp = (void *) data; struct l2cap_ecred_conn_rsp *rsp = (void *) data;
struct hci_conn *hcon = conn->hcon; struct hci_conn *hcon = conn->hcon;
u16 mtu, mps, credits, result; u16 mtu, mps, credits, result;
struct l2cap_chan *chan; struct l2cap_chan *chan, *tmp;
int err = 0, sec_level; int err = 0, sec_level;
int i = 0; int i = 0;
@@ -6074,7 +6074,7 @@ static inline int l2cap_ecred_conn_rsp(struct l2cap_conn *conn,
cmd_len -= sizeof(*rsp); cmd_len -= sizeof(*rsp);
list_for_each_entry(chan, &conn->chan_l, list) { list_for_each_entry_safe(chan, tmp, &conn->chan_l, list) {
u16 dcid; u16 dcid;
if (chan->ident != cmd->ident || if (chan->ident != cmd->ident ||