xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

afs: Fix incorrect error handling in afs_xattr_get_acl()

Browse Source 
Fix incorrect error handling in afs_xattr_get_acl() where there appears to
be a redundant assignment before return, but in fact the return should be a
goto to the error handling at the end of the function.

Fixes: 260f082bae ("afs: Get an AFS3 ACL as an xattr")
Addresses-Coverity: ("Unused Value")
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Joe Perches <joe@perches.com>
This commit is contained in:
David Howells
2019-05-12 08:05:10 +01:00
parent a1b879eefc
commit cc1dd5c85c
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
fs/afs/xattr.c
View File

@@ -71,11 +71,10 @@ static int afs_xattr_get_acl(const struct xattr_handler *handler,
if (ret == 0) { if (ret == 0) {
ret = acl->size; ret = acl->size;
if (size > 0) { if (size > 0) {
ret = -ERANGE; if (acl->size <= size)
if (acl->size > size)
return -ERANGE;
memcpy(buffer, acl->data, acl->size); memcpy(buffer, acl->data, acl->size);
ret = acl->size; else
ret = -ERANGE;
} }
kfree(acl); kfree(acl);
} }