USB: move many drivers to use DEVICE_ATTR_WO
Instead of "open coding" a DEVICE_ATTR() define, use the DEVICE_ATTR_WO() macro instead, which does everything properly instead. This does require a few static functions to be renamed to work properly, but thanks to a script from Joe Perches, this was easily done. Reported-by: Joe Perches <joe@perches.com> Cc: Peter Chen <Peter.Chen@nxp.com> Cc: Valentina Manea <valentina.manea.m@gmail.com> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com> Acked-by: Johan Hovold <johan@kernel.org> Acked-by: Shuah Khan <shuahkh@osg.samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
@@ -90,7 +90,7 @@ unlock:
|
||||
}
|
||||
static BIN_ATTR_RO(dev_desc, sizeof(struct usb_device_descriptor));
|
||||
|
||||
static ssize_t store_sockfd(struct device *dev, struct device_attribute *attr,
|
||||
static ssize_t usbip_sockfd_store(struct device *dev, struct device_attribute *attr,
|
||||
const char *in, size_t count)
|
||||
{
|
||||
struct vudc *udc = (struct vudc *) dev_get_drvdata(dev);
|
||||
@@ -180,7 +180,7 @@ unlock:
|
||||
|
||||
return ret;
|
||||
}
|
||||
static DEVICE_ATTR(usbip_sockfd, S_IWUSR, NULL, store_sockfd);
|
||||
static DEVICE_ATTR_WO(usbip_sockfd);
|
||||
|
||||
static ssize_t usbip_status_show(struct device *dev,
|
||||
struct device_attribute *attr, char *out)
|
||||
|
Reference in New Issue
Block a user