xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

regmap: allow to disable all locking mechanisms

Browse Source 
We have a use case in the at24 EEPROM driver (recently converted to
using regmap instead of raw i2c/smbus calls) where we read from/write
to the regmap in a loop, while protecting the entire loop with
a mutex.

Currently this implicitly makes us use two mutexes - one in the driver
and one in regmap. While browsing the code for similar use cases I
noticed a significant number of places where locking *seems* redundant.

Allow users to completely disable any locking mechanisms in regmap
config.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Bartosz Golaszewski
2017-12-06 15:26:21 +01:00
committed by Mark Brown
parent 4fbd8d194f
commit c9b41fcf27
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/base/regmap/regmap.c
View File

@@ -459,6 +459,11 @@ static void regmap_unlock_hwlock_irqrestore(void *__map)
}
#endif
static void regmap_lock_unlock_empty(void *__map)
{
}
static void regmap_lock_mutex(void *__map)
{
struct regmap *map = __map;
@@ -669,7 +674,9 @@ struct regmap *__regmap_init(struct device *dev,
goto err;
}
if (config->lock && config->unlock) {
if (config->disable_locking) {
map->lock = map->unlock = regmap_lock_unlock_empty;
} else if (config->lock && config->unlock) {
map->lock = config->lock;
map->unlock = config->unlock;
map->lock_arg = config->lock_arg;