usb: gadget: remove incorrect __init/__exit annotations
A recent change introduced a link error for the composite printer gadget driver: `printer_unbind' referenced in section `.ref.data' of drivers/built-in.o: defined in discarded section `.exit.text' of drivers/built-in.o Evidently the unbind function should not be marked __exit here, because it is called through a callback pointer that is not necessarily discarded, __composite_unbind() is indeed called from the error path of composite_bind(), which can never work for a built-in driver. Looking at the surrounding code, I found the same problem in all other composite gadget drivers in both the bind and unbind functions, as well as the udc platform driver 'remove' functions. Those will break if anyone uses the 'unbind' sysfs attribute to detach a device from a built-in driver. This patch removes the incorrect annotations from all the gadget drivers. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:

zatwierdzone przez
Felipe Balbi

rodzic
197d0bdf8b
commit
c94e289f19
@@ -284,7 +284,7 @@ fail_1:
|
||||
return -ENODEV;
|
||||
}
|
||||
|
||||
static int __init dbgp_bind(struct usb_gadget *gadget,
|
||||
static int dbgp_bind(struct usb_gadget *gadget,
|
||||
struct usb_gadget_driver *driver)
|
||||
{
|
||||
int err, stp;
|
||||
@@ -406,7 +406,7 @@ fail:
|
||||
return err;
|
||||
}
|
||||
|
||||
static __refdata struct usb_gadget_driver dbgp_driver = {
|
||||
static struct usb_gadget_driver dbgp_driver = {
|
||||
.function = "dbgp",
|
||||
.max_speed = USB_SPEED_HIGH,
|
||||
.bind = dbgp_bind,
|
||||
|
Reference in New Issue
Block a user