xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform driver: fix use-after-free in platform_device_del()

Browse Source 
In platform_device_del(), the device is still used after a call to
device_del(). At this point there is no guarantee that the device is
still there and there could be a use-after-free access. Move the
call to device_remove_properties() before device_del() to fix that.

Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jerome Marchand
2016-07-25 16:13:32 +02:00
committed by Greg Kroah-Hartman
parent bea5b158ff
commit c90aab9c96
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/base/platform.c
View File

@@ -434,6 +434,7 @@ void platform_device_del(struct platform_device *pdev)
int i; int i;
if (pdev) { if (pdev) {
device_remove_properties(&pdev->dev);
device_del(&pdev->dev); device_del(&pdev->dev);
if (pdev->id_auto) { if (pdev->id_auto) {
@@ -446,8 +447,6 @@ void platform_device_del(struct platform_device *pdev)
if (r->parent) if (r->parent)
release_resource(r); release_resource(r);
} }
device_remove_properties(&pdev->dev);
} }
} }
EXPORT_SYMBOL_GPL(platform_device_del); EXPORT_SYMBOL_GPL(platform_device_del);