xfs: exclude never-released buffers from buftarg I/O accounting
The upcoming buftarg I/O accounting mechanism maintains a count of all buffers that have undergone I/O in the current hold-release cycle. Certain buffers associated with core infrastructure (e.g., the xfs_mount superblock buffer, log buffers) are never released, however. This means that accounting I/O submission on such buffers elevates the buftarg count indefinitely and could lead to lockup on unmount. Define a new buffer flag to explicitly exclude buffers from buftarg I/O accounting. Set the flag on the superblock and associated log buffers. Signed-off-by: Brian Foster <bfoster@redhat.com> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:

committed by
Dave Chinner

parent
5539d36752
commit
c891c30a4d
@@ -1415,7 +1415,7 @@ xlog_alloc_log(
|
||||
*/
|
||||
error = -ENOMEM;
|
||||
bp = xfs_buf_alloc(mp->m_logdev_targp, XFS_BUF_DADDR_NULL,
|
||||
BTOBB(log->l_iclog_size), 0);
|
||||
BTOBB(log->l_iclog_size), XBF_NO_IOACCT);
|
||||
if (!bp)
|
||||
goto out_free_log;
|
||||
|
||||
@@ -1454,7 +1454,8 @@ xlog_alloc_log(
|
||||
prev_iclog = iclog;
|
||||
|
||||
bp = xfs_buf_get_uncached(mp->m_logdev_targp,
|
||||
BTOBB(log->l_iclog_size), 0);
|
||||
BTOBB(log->l_iclog_size),
|
||||
XBF_NO_IOACCT);
|
||||
if (!bp)
|
||||
goto out_free_iclog;
|
||||
|
||||
|
Reference in New Issue
Block a user