Merge branch 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull misc compat stuff updates from Al Viro: "This part is basically untangling various compat stuff. Compat syscalls moved to their native counterparts, getting rid of quite a bit of double-copying and/or set_fs() uses. A lot of field-by-field copyin/copyout killed off. - kernel/compat.c is much closer to containing just the copyin/copyout of compat structs. Not all compat syscalls are gone from it yet, but it's getting there. - ipc/compat_mq.c killed off completely. - block/compat_ioctl.c cleaned up; floppy compat ioctls moved to drivers/block/floppy.c where they belong. Yes, there are several drivers that implement some of the same ioctls. Some are m68k and one is 32bit-only pmac. drivers/block/floppy.c is the only one in that bunch that can be built on biarch" * 'misc.compat' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: mqueue: move compat syscalls to native ones usbdevfs: get rid of field-by-field copyin compat_hdio_ioctl: get rid of set_fs() take floppy compat ioctls to sodding floppy.c ipmi: get rid of field-by-field __get_user() ipmi: get COMPAT_IPMICTL_RECEIVE_MSG in sync with the native one rt_sigtimedwait(): move compat to native select: switch compat_{get,put}_fd_set() to compat_{get,put}_bitmap() put_compat_rusage(): switch to copy_to_user() sigpending(): move compat to native getrlimit()/setrlimit(): move compat to native times(2): move compat to native compat_{get,put}_bitmap(): use unsafe_{get,put}_user() fb_get_fscreeninfo(): don't bother with do_fb_ioctl() do_sigaltstack(): lift copying to/from userland into callers take compat_sys_old_getrlimit() to native syscall trim __ARCH_WANT_SYS_OLD_GETRLIMIT
This commit is contained in:
@@ -1966,27 +1966,21 @@ static int proc_disconnectsignal_compat(struct usb_dev_state *ps, void __user *a
|
||||
static int get_urb32(struct usbdevfs_urb *kurb,
|
||||
struct usbdevfs_urb32 __user *uurb)
|
||||
{
|
||||
__u32 uptr;
|
||||
if (!access_ok(VERIFY_READ, uurb, sizeof(*uurb)) ||
|
||||
__get_user(kurb->type, &uurb->type) ||
|
||||
__get_user(kurb->endpoint, &uurb->endpoint) ||
|
||||
__get_user(kurb->status, &uurb->status) ||
|
||||
__get_user(kurb->flags, &uurb->flags) ||
|
||||
__get_user(kurb->buffer_length, &uurb->buffer_length) ||
|
||||
__get_user(kurb->actual_length, &uurb->actual_length) ||
|
||||
__get_user(kurb->start_frame, &uurb->start_frame) ||
|
||||
__get_user(kurb->number_of_packets, &uurb->number_of_packets) ||
|
||||
__get_user(kurb->error_count, &uurb->error_count) ||
|
||||
__get_user(kurb->signr, &uurb->signr))
|
||||
struct usbdevfs_urb32 urb32;
|
||||
if (copy_from_user(&urb32, uurb, sizeof(*uurb)))
|
||||
return -EFAULT;
|
||||
|
||||
if (__get_user(uptr, &uurb->buffer))
|
||||
return -EFAULT;
|
||||
kurb->buffer = compat_ptr(uptr);
|
||||
if (__get_user(uptr, &uurb->usercontext))
|
||||
return -EFAULT;
|
||||
kurb->usercontext = compat_ptr(uptr);
|
||||
|
||||
kurb->type = urb32.type;
|
||||
kurb->endpoint = urb32.endpoint;
|
||||
kurb->status = urb32.status;
|
||||
kurb->flags = urb32.flags;
|
||||
kurb->buffer = compat_ptr(urb32.buffer);
|
||||
kurb->buffer_length = urb32.buffer_length;
|
||||
kurb->actual_length = urb32.actual_length;
|
||||
kurb->start_frame = urb32.start_frame;
|
||||
kurb->number_of_packets = urb32.number_of_packets;
|
||||
kurb->error_count = urb32.error_count;
|
||||
kurb->signr = urb32.signr;
|
||||
kurb->usercontext = compat_ptr(urb32.usercontext);
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -2198,18 +2192,14 @@ static int proc_ioctl_default(struct usb_dev_state *ps, void __user *arg)
|
||||
#ifdef CONFIG_COMPAT
|
||||
static int proc_ioctl_compat(struct usb_dev_state *ps, compat_uptr_t arg)
|
||||
{
|
||||
struct usbdevfs_ioctl32 __user *uioc;
|
||||
struct usbdevfs_ioctl32 ioc32;
|
||||
struct usbdevfs_ioctl ctrl;
|
||||
u32 udata;
|
||||
|
||||
uioc = compat_ptr((long)arg);
|
||||
if (!access_ok(VERIFY_READ, uioc, sizeof(*uioc)) ||
|
||||
__get_user(ctrl.ifno, &uioc->ifno) ||
|
||||
__get_user(ctrl.ioctl_code, &uioc->ioctl_code) ||
|
||||
__get_user(udata, &uioc->data))
|
||||
if (copy_from_user(&ioc32, compat_ptr(arg), sizeof(ioc32)))
|
||||
return -EFAULT;
|
||||
ctrl.data = compat_ptr(udata);
|
||||
|
||||
ctrl.ifno = ioc32.ifno;
|
||||
ctrl.ioctl_code = ioc32.ioctl_code;
|
||||
ctrl.data = compat_ptr(ioc32.data);
|
||||
return proc_ioctl(ps, &ctrl);
|
||||
}
|
||||
#endif
|
||||
|
Reference in New Issue
Block a user