[WATCHDOG] spin_lock_init() fixes
Some watchdog drivers initialize global spinlocks in module's init function which is tolerable, but some do it in PCI probe function. So, switch to static initialization to fix theoretical bugs and, more importantly, stop giving people bad examples. Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru> Signed-off-by: Wim Van Sebroeck <wim@iguana.be> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:

committato da
Wim Van Sebroeck

parent
2ba7d7b39f
commit
c7dfd0cca3
@@ -48,7 +48,7 @@
|
||||
|
||||
static struct platform_device *ibwdt_platform_device;
|
||||
static unsigned long ibwdt_is_open;
|
||||
static spinlock_t ibwdt_lock;
|
||||
static DEFINE_SPINLOCK(ibwdt_lock);
|
||||
static char expect_close;
|
||||
|
||||
/* Module information */
|
||||
@@ -308,8 +308,6 @@ static int __devinit ibwdt_probe(struct platform_device *dev)
|
||||
{
|
||||
int res;
|
||||
|
||||
spin_lock_init(&ibwdt_lock);
|
||||
|
||||
#if WDT_START != WDT_STOP
|
||||
if (!request_region(WDT_STOP, 1, "IB700 WDT")) {
|
||||
printk (KERN_ERR PFX "STOP method I/O %X is not available.\n", WDT_STOP);
|
||||
|
Fai riferimento in un nuovo problema
Block a user