[ARM] ecard: add helper function for setting ecard irq ops
Rather than having every driver fiddle about setting its private IRQ operations and data, provide a helper function to contain this functionality in one place. Arrange to remove the driver-private IRQ operations and data when the device is removed from the driver, and remove the driver private code to do this. This fixes potential problems caused by drivers forgetting to remove these hooks. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
This commit is contained in:
@@ -710,8 +710,7 @@ etherh_probe(struct expansion_card *ec, const struct ecard_id *id)
|
||||
* IRQ and control port handling - only for non-NIC slot cards.
|
||||
*/
|
||||
if (ec->slot_no != 8) {
|
||||
ec->ops = ðerh_ops;
|
||||
ec->irq_data = eh;
|
||||
ecard_setirq(ec, ðerh_ops, eh);
|
||||
} else {
|
||||
/*
|
||||
* If we're in the NIC slot, make sure the IRQ is enabled
|
||||
@@ -778,7 +777,6 @@ static void __devexit etherh_remove(struct expansion_card *ec)
|
||||
ecard_set_drvdata(ec, NULL);
|
||||
|
||||
unregister_netdev(dev);
|
||||
ec->ops = NULL;
|
||||
|
||||
if (eh->ioc_fast)
|
||||
iounmap(eh->ioc_fast);
|
||||
|
Reference in New Issue
Block a user