tcp: Fix a data-race around sysctl_tcp_probe_interval.
[ Upstream commit 2a85388f1d94a9f8b5a529118a2c5eaa0520d85c ]
While reading sysctl_tcp_probe_interval, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 05cbc0db03
("ipv4: Create probe timer for tcp PMTU as per RFC4821")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
d452ce36f2
commit
c61aede097
@@ -2278,7 +2278,7 @@ static inline void tcp_mtu_check_reprobe(struct sock *sk)
|
|||||||
u32 interval;
|
u32 interval;
|
||||||
s32 delta;
|
s32 delta;
|
||||||
|
|
||||||
interval = net->ipv4.sysctl_tcp_probe_interval;
|
interval = READ_ONCE(net->ipv4.sysctl_tcp_probe_interval);
|
||||||
delta = tcp_jiffies32 - icsk->icsk_mtup.probe_timestamp;
|
delta = tcp_jiffies32 - icsk->icsk_mtup.probe_timestamp;
|
||||||
if (unlikely(delta >= interval * HZ)) {
|
if (unlikely(delta >= interval * HZ)) {
|
||||||
int mss = tcp_current_mss(sk);
|
int mss = tcp_current_mss(sk);
|
||||||
|
Reference in New Issue
Block a user