xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

e1000e: cleanup NAPI routine

Browse Source 
Rename NAPI polling routine and a parameter with more appropriate names,
refactor a conditional branch to get rid of an unnecessary goto/label and
fix a line exceeding 80 columns.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
This commit is contained in:
Bruce Allan
2012-03-20 03:48:19 +00:00
committed by Jeff Kirsher
parent 397c020ac2
commit c58c8a784b
1 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/net/ethernet/intel/e1000e/netdev.c
View File

@@ -2524,33 +2524,31 @@ err:
} }
/** /**
* e1000_clean - NAPI Rx polling callback * e1000e_poll - NAPI Rx polling callback
* @napi: struct associated with this polling callback * @napi: struct associated with this polling callback
* @budget: amount of packets driver is allowed to process this poll * @weight: number of packets driver is allowed to process this poll
**/ **/
static int e1000_clean(struct napi_struct *napi, int budget) static int e1000e_poll(struct napi_struct *napi, int weight)
{ {
struct e1000_adapter *adapter = container_of(napi, struct e1000_adapter, napi); struct e1000_adapter *adapter = container_of(napi, struct e1000_adapter,
napi);
struct e1000_hw *hw = &adapter->hw; struct e1000_hw *hw = &adapter->hw;
struct net_device *poll_dev = adapter->netdev; struct net_device *poll_dev = adapter->netdev;
int tx_cleaned = 1, work_done = 0; int tx_cleaned = 1, work_done = 0;
adapter = netdev_priv(poll_dev); adapter = netdev_priv(poll_dev);
if (adapter->msix_entries && if (!adapter->msix_entries ||
!(adapter->rx_ring->ims_val & adapter->tx_ring->ims_val)) (adapter->rx_ring->ims_val & adapter->tx_ring->ims_val))
goto clean_rx;
tx_cleaned = e1000_clean_tx_irq(adapter->tx_ring); tx_cleaned = e1000_clean_tx_irq(adapter->tx_ring);
clean_rx: adapter->clean_rx(adapter->rx_ring, &work_done, weight);
adapter->clean_rx(adapter->rx_ring, &work_done, budget);
if (!tx_cleaned) if (!tx_cleaned)
work_done = budget; work_done = weight;
/* If budget not fully consumed, exit the polling mode */ /* If weight not fully consumed, exit the polling mode */
if (work_done < budget) { if (work_done < weight) {
if (adapter->itr_setting & 3) if (adapter->itr_setting & 3)
e1000_set_itr(adapter); e1000_set_itr(adapter);
napi_complete(napi); napi_complete(napi);
@@ -6201,7 +6199,7 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
netdev->netdev_ops = &e1000e_netdev_ops; netdev->netdev_ops = &e1000e_netdev_ops;
e1000e_set_ethtool_ops(netdev); e1000e_set_ethtool_ops(netdev);
netdev->watchdog_timeo = 5 * HZ; netdev->watchdog_timeo = 5 * HZ;
netif_napi_add(netdev, &adapter->napi, e1000_clean, 64); netif_napi_add(netdev, &adapter->napi, e1000e_poll, 64);
strlcpy(netdev->name, pci_name(pdev), sizeof(netdev->name)); strlcpy(netdev->name, pci_name(pdev), sizeof(netdev->name));
netdev->mem_start = mmio_start; netdev->mem_start = mmio_start;