SUNRPC: Rename svc_create_xprt()
[ Upstream commit 352ad31448fecc78a2e9b78da64eea5d63b8d0ce ] Clean up: Use the "svc_xprt_<task>" function naming convention as is used for other external APIs. Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
9a43ddd6b6
commit
c58a9cfd20
@@ -197,8 +197,8 @@ static int create_lockd_listener(struct svc_serv *serv, const char *name,
|
|||||||
|
|
||||||
xprt = svc_find_xprt(serv, name, net, family, 0);
|
xprt = svc_find_xprt(serv, name, net, family, 0);
|
||||||
if (xprt == NULL)
|
if (xprt == NULL)
|
||||||
return svc_create_xprt(serv, name, net, family, port,
|
return svc_xprt_create(serv, name, net, family, port,
|
||||||
SVC_SOCK_DEFAULTS, cred);
|
SVC_SOCK_DEFAULTS, cred);
|
||||||
svc_xprt_put(xprt);
|
svc_xprt_put(xprt);
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
@@ -45,18 +45,18 @@ static int nfs4_callback_up_net(struct svc_serv *serv, struct net *net)
|
|||||||
int ret;
|
int ret;
|
||||||
struct nfs_net *nn = net_generic(net, nfs_net_id);
|
struct nfs_net *nn = net_generic(net, nfs_net_id);
|
||||||
|
|
||||||
ret = svc_create_xprt(serv, "tcp", net, PF_INET,
|
ret = svc_xprt_create(serv, "tcp", net, PF_INET,
|
||||||
nfs_callback_set_tcpport, SVC_SOCK_ANONYMOUS,
|
nfs_callback_set_tcpport, SVC_SOCK_ANONYMOUS,
|
||||||
cred);
|
cred);
|
||||||
if (ret <= 0)
|
if (ret <= 0)
|
||||||
goto out_err;
|
goto out_err;
|
||||||
nn->nfs_callback_tcpport = ret;
|
nn->nfs_callback_tcpport = ret;
|
||||||
dprintk("NFS: Callback listener port = %u (af %u, net %x)\n",
|
dprintk("NFS: Callback listener port = %u (af %u, net %x)\n",
|
||||||
nn->nfs_callback_tcpport, PF_INET, net->ns.inum);
|
nn->nfs_callback_tcpport, PF_INET, net->ns.inum);
|
||||||
|
|
||||||
ret = svc_create_xprt(serv, "tcp", net, PF_INET6,
|
ret = svc_xprt_create(serv, "tcp", net, PF_INET6,
|
||||||
nfs_callback_set_tcpport, SVC_SOCK_ANONYMOUS,
|
nfs_callback_set_tcpport, SVC_SOCK_ANONYMOUS,
|
||||||
cred);
|
cred);
|
||||||
if (ret > 0) {
|
if (ret > 0) {
|
||||||
nn->nfs_callback_tcpport6 = ret;
|
nn->nfs_callback_tcpport6 = ret;
|
||||||
dprintk("NFS: Callback listener port = %u (af %u, net %x)\n",
|
dprintk("NFS: Callback listener port = %u (af %u, net %x)\n",
|
||||||
|
@@ -772,13 +772,13 @@ static ssize_t __write_ports_addxprt(char *buf, struct net *net, const struct cr
|
|||||||
if (err != 0)
|
if (err != 0)
|
||||||
return err;
|
return err;
|
||||||
|
|
||||||
err = svc_create_xprt(nn->nfsd_serv, transport, net,
|
err = svc_xprt_create(nn->nfsd_serv, transport, net,
|
||||||
PF_INET, port, SVC_SOCK_ANONYMOUS, cred);
|
PF_INET, port, SVC_SOCK_ANONYMOUS, cred);
|
||||||
if (err < 0)
|
if (err < 0)
|
||||||
goto out_err;
|
goto out_err;
|
||||||
|
|
||||||
err = svc_create_xprt(nn->nfsd_serv, transport, net,
|
err = svc_xprt_create(nn->nfsd_serv, transport, net,
|
||||||
PF_INET6, port, SVC_SOCK_ANONYMOUS, cred);
|
PF_INET6, port, SVC_SOCK_ANONYMOUS, cred);
|
||||||
if (err < 0 && err != -EAFNOSUPPORT)
|
if (err < 0 && err != -EAFNOSUPPORT)
|
||||||
goto out_close;
|
goto out_close;
|
||||||
|
|
||||||
|
@@ -293,13 +293,13 @@ static int nfsd_init_socks(struct net *net, const struct cred *cred)
|
|||||||
if (!list_empty(&nn->nfsd_serv->sv_permsocks))
|
if (!list_empty(&nn->nfsd_serv->sv_permsocks))
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
error = svc_create_xprt(nn->nfsd_serv, "udp", net, PF_INET, NFS_PORT,
|
error = svc_xprt_create(nn->nfsd_serv, "udp", net, PF_INET, NFS_PORT,
|
||||||
SVC_SOCK_DEFAULTS, cred);
|
SVC_SOCK_DEFAULTS, cred);
|
||||||
if (error < 0)
|
if (error < 0)
|
||||||
return error;
|
return error;
|
||||||
|
|
||||||
error = svc_create_xprt(nn->nfsd_serv, "tcp", net, PF_INET, NFS_PORT,
|
error = svc_xprt_create(nn->nfsd_serv, "tcp", net, PF_INET, NFS_PORT,
|
||||||
SVC_SOCK_DEFAULTS, cred);
|
SVC_SOCK_DEFAULTS, cred);
|
||||||
if (error < 0)
|
if (error < 0)
|
||||||
return error;
|
return error;
|
||||||
|
|
||||||
|
@@ -127,9 +127,10 @@ int svc_reg_xprt_class(struct svc_xprt_class *);
|
|||||||
void svc_unreg_xprt_class(struct svc_xprt_class *);
|
void svc_unreg_xprt_class(struct svc_xprt_class *);
|
||||||
void svc_xprt_init(struct net *, struct svc_xprt_class *, struct svc_xprt *,
|
void svc_xprt_init(struct net *, struct svc_xprt_class *, struct svc_xprt *,
|
||||||
struct svc_serv *);
|
struct svc_serv *);
|
||||||
int svc_create_xprt(struct svc_serv *, const char *, struct net *,
|
int svc_xprt_create(struct svc_serv *serv, const char *xprt_name,
|
||||||
const int, const unsigned short, int,
|
struct net *net, const int family,
|
||||||
const struct cred *);
|
const unsigned short port, int flags,
|
||||||
|
const struct cred *cred);
|
||||||
void svc_xprt_received(struct svc_xprt *xprt);
|
void svc_xprt_received(struct svc_xprt *xprt);
|
||||||
void svc_xprt_enqueue(struct svc_xprt *xprt);
|
void svc_xprt_enqueue(struct svc_xprt *xprt);
|
||||||
void svc_xprt_put(struct svc_xprt *xprt);
|
void svc_xprt_put(struct svc_xprt *xprt);
|
||||||
|
@@ -272,7 +272,7 @@ void svc_add_new_perm_xprt(struct svc_serv *serv, struct svc_xprt *new)
|
|||||||
svc_xprt_received(new);
|
svc_xprt_received(new);
|
||||||
}
|
}
|
||||||
|
|
||||||
static int _svc_create_xprt(struct svc_serv *serv, const char *xprt_name,
|
static int _svc_xprt_create(struct svc_serv *serv, const char *xprt_name,
|
||||||
struct net *net, const int family,
|
struct net *net, const int family,
|
||||||
const unsigned short port, int flags,
|
const unsigned short port, int flags,
|
||||||
const struct cred *cred)
|
const struct cred *cred)
|
||||||
@@ -308,21 +308,35 @@ static int _svc_create_xprt(struct svc_serv *serv, const char *xprt_name,
|
|||||||
return -EPROTONOSUPPORT;
|
return -EPROTONOSUPPORT;
|
||||||
}
|
}
|
||||||
|
|
||||||
int svc_create_xprt(struct svc_serv *serv, const char *xprt_name,
|
/**
|
||||||
|
* svc_xprt_create - Add a new listener to @serv
|
||||||
|
* @serv: target RPC service
|
||||||
|
* @xprt_name: transport class name
|
||||||
|
* @net: network namespace
|
||||||
|
* @family: network address family
|
||||||
|
* @port: listener port
|
||||||
|
* @flags: SVC_SOCK flags
|
||||||
|
* @cred: credential to bind to this transport
|
||||||
|
*
|
||||||
|
* Return values:
|
||||||
|
* %0: New listener added successfully
|
||||||
|
* %-EPROTONOSUPPORT: Requested transport type not supported
|
||||||
|
*/
|
||||||
|
int svc_xprt_create(struct svc_serv *serv, const char *xprt_name,
|
||||||
struct net *net, const int family,
|
struct net *net, const int family,
|
||||||
const unsigned short port, int flags,
|
const unsigned short port, int flags,
|
||||||
const struct cred *cred)
|
const struct cred *cred)
|
||||||
{
|
{
|
||||||
int err;
|
int err;
|
||||||
|
|
||||||
err = _svc_create_xprt(serv, xprt_name, net, family, port, flags, cred);
|
err = _svc_xprt_create(serv, xprt_name, net, family, port, flags, cred);
|
||||||
if (err == -EPROTONOSUPPORT) {
|
if (err == -EPROTONOSUPPORT) {
|
||||||
request_module("svc%s", xprt_name);
|
request_module("svc%s", xprt_name);
|
||||||
err = _svc_create_xprt(serv, xprt_name, net, family, port, flags, cred);
|
err = _svc_xprt_create(serv, xprt_name, net, family, port, flags, cred);
|
||||||
}
|
}
|
||||||
return err;
|
return err;
|
||||||
}
|
}
|
||||||
EXPORT_SYMBOL_GPL(svc_create_xprt);
|
EXPORT_SYMBOL_GPL(svc_xprt_create);
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Copy the local and remote xprt addresses to the rqstp structure
|
* Copy the local and remote xprt addresses to the rqstp structure
|
||||||
|
Reference in New Issue
Block a user