xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

events: Reuse value read using READ_ONCE instead of re-reading it

Browse Source 
commit b89a05b21f46150ac10a962aa50109250b56b03b upstream.

In perf_event_addr_filters_apply, the task associated with
the event (event->ctx->task) is read using READ_ONCE at the beginning
of the function, checked, and then re-read from event->ctx->task,
voiding all guarantees of the checks. Reuse the value that was read by
READ_ONCE to ensure the consistency of the task struct throughout the
function.

Fixes: 375637bc52 ("perf/core: Introduce address range filtering")
Signed-off-by: Baptiste Lepers <baptiste.lepers@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20210906015310.12802-1-baptiste.lepers@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Baptiste Lepers
2021-09-06 11:53:10 +10:00
committed by Greg Kroah-Hartman
parent 8f8ad122ff
commit c5102ced8a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/events/core.c
View File

@@ -9973,7 +9973,7 @@ static void perf_event_addr_filters_apply(struct perf_event *event)
return; return;
if (ifh->nr_file_filters) { if (ifh->nr_file_filters) {
mm = get_task_mm(event->ctx->task); mm = get_task_mm(task);
if (!mm) if (!mm)
goto restart; goto restart;