NFC: The core part should generate the target index
The target index can be used by userspace to uniquely identify a target and thus should be kept unique, per NFC adapter. Moreover, some protocols do not provide a logical index when discovering new targets, so we have to generate one for them. For NCI or pn533 to fetch their logical index, we added a logical_idx field to the target structure. Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:

committed by
John W. Linville

parent
0efbf7fb30
commit
c4fbb6515a
@@ -227,7 +227,7 @@ static void nci_add_new_target(struct nci_dev *ndev,
|
||||
|
||||
for (i = 0; i < ndev->n_targets; i++) {
|
||||
target = &ndev->targets[i];
|
||||
if (target->idx == ntf->rf_discovery_id) {
|
||||
if (target->logical_idx == ntf->rf_discovery_id) {
|
||||
/* This target already exists, add the new protocol */
|
||||
nci_add_new_protocol(ndev, target, ntf->rf_protocol,
|
||||
ntf->rf_tech_and_mode,
|
||||
@@ -248,10 +248,10 @@ static void nci_add_new_target(struct nci_dev *ndev,
|
||||
ntf->rf_tech_and_mode,
|
||||
&ntf->rf_tech_specific_params);
|
||||
if (!rc) {
|
||||
target->idx = ntf->rf_discovery_id;
|
||||
target->logical_idx = ntf->rf_discovery_id;
|
||||
ndev->n_targets++;
|
||||
|
||||
pr_debug("target_idx %d, n_targets %d\n", target->idx,
|
||||
pr_debug("logical idx %d, n_targets %d\n", target->logical_idx,
|
||||
ndev->n_targets);
|
||||
}
|
||||
}
|
||||
@@ -372,10 +372,11 @@ static void nci_target_auto_activated(struct nci_dev *ndev,
|
||||
if (rc)
|
||||
return;
|
||||
|
||||
target->idx = ntf->rf_discovery_id;
|
||||
target->logical_idx = ntf->rf_discovery_id;
|
||||
ndev->n_targets++;
|
||||
|
||||
pr_debug("target_idx %d, n_targets %d\n", target->idx, ndev->n_targets);
|
||||
pr_debug("logical idx %d, n_targets %d\n",
|
||||
target->logical_idx, ndev->n_targets);
|
||||
|
||||
nfc_targets_found(ndev->nfc_dev, ndev->targets, ndev->n_targets);
|
||||
}
|
||||
|
Reference in New Issue
Block a user