xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

s390/scm: remove superfluous lock

Browse Source 
Remove the spinlock from struct scm_device. drvdata and attributes
are guarded via device_lock.

Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
This commit is contained in:
Sebastian Ott
2012-09-04 19:36:41 +02:00
committed by Martin Schwidefsky
parent 50ab9a9a60
commit c3e6d407c0
3 changed files with 3 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/s390/cio/scm.c
View File

@@ -5,7 +5,6 @@
* Author(s): Sebastian Ott <sebott@linux.vnet.ibm.com>
*/
#include <linux/spinlock.h>
#include <linux/device.h>
#include <linux/module.h>
#include <linux/mutex.h>
@@ -134,9 +133,9 @@ static ssize_t show_##name(struct device *dev, \
struct scm_device *scmdev = to_scm_dev(dev); \
int ret; \
\
spin_lock(&scmdev->lock); \
device_lock(dev); \
ret = sprintf(buf, "%u\n", scmdev->attrs.name); \
spin_unlock(&scmdev->lock); \
device_unlock(dev); \
\
return ret; \
} \
@@ -193,7 +192,6 @@ static void scmdev_setup(struct scm_device *scmdev, struct sale *sale,
scmdev->dev.bus = &scm_bus_type;
scmdev->dev.release = scmdev_release;
scmdev->dev.groups = scmdev_attr_groups;
spin_lock_init(&scmdev->lock);
}
/*