tcp: replace dst_confirm with sk_dst_confirm
When same struct dst_entry can be used for many different neighbours we can not use it for pending confirmations. Use the new sk_dst_confirm() helper to propagate the indication from received packets to sock_confirm_neigh(). Reported-by: YueHaibing <yuehaibing@huawei.com> Fixes:5110effee8
("net: Do delayed neigh confirmation.") Fixes:f2bb4bedf3
("ipv4: Cache output routes in fib_info nexthops.") Tested-by: YueHaibing <yuehaibing@huawei.com> Signed-off-by: Julian Anastasov <ja@ssi.bg> Acked-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
c86a773c78
commit
c3a2e83705
@@ -375,12 +375,10 @@ void tcp_update_metrics(struct sock *sk)
|
||||
u32 val;
|
||||
int m;
|
||||
|
||||
sk_dst_confirm(sk);
|
||||
if (sysctl_tcp_nometrics_save || !dst)
|
||||
return;
|
||||
|
||||
if (dst->flags & DST_HOST)
|
||||
dst_confirm(dst);
|
||||
|
||||
rcu_read_lock();
|
||||
if (icsk->icsk_backoff || !tp->srtt_us) {
|
||||
/* This session failed to estimate rtt. Why?
|
||||
@@ -493,11 +491,10 @@ void tcp_init_metrics(struct sock *sk)
|
||||
struct tcp_metrics_block *tm;
|
||||
u32 val, crtt = 0; /* cached RTT scaled by 8 */
|
||||
|
||||
sk_dst_confirm(sk);
|
||||
if (!dst)
|
||||
goto reset;
|
||||
|
||||
dst_confirm(dst);
|
||||
|
||||
rcu_read_lock();
|
||||
tm = tcp_get_metrics(sk, dst, true);
|
||||
if (!tm) {
|
||||
|
Reference in New Issue
Block a user