xiaomi-sm8450/android_kernel_xiaomi_sm8450
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

UPSTREAM: mm/damon/dbgfs: protect targets destructions with kdamond_lock

Browse Source 
DAMON debugfs interface iterates current monitoring targets in
'dbgfs_target_ids_read()' while holding the corresponding
'kdamond_lock'.  However, it also destructs the monitoring targets in
'dbgfs_before_terminate()' without holding the lock.  This can result in
a use_after_free bug.  This commit avoids the race by protecting the
destruction with the corresponding 'kdamond_lock'.

Link: https://lkml.kernel.org/r/20211221094447.2241-1-sj@kernel.org
Reported-by: Sangwoo Bae <sangwoob@amazon.com>
Fixes: 4bc05954d007 ("mm/damon: implement a debugfs-based user space interface")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org>	[5.15.x]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

(cherry picked from commit 34796417964b8d0aef45a99cf6c2d20cebe33733)

Bug: 228223814
Signed-off-by: Hailong Tu <tuhailong@oppo.com>
Change-Id: I27e10c0e1ccc6c28c5a948a246e45db7a0338bed
This commit is contained in:
SeongJae Park
2021-12-24 21:12:54 -08:00
committed by Hailong Tu
parent 82bb332bf0
commit c3939031fb
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mm/damon/dbgfs.c
View File

@@ -650,10 +650,12 @@ static void dbgfs_before_terminate(struct damon_ctx *ctx)
if (!targetid_is_pid(ctx)) if (!targetid_is_pid(ctx))
return; return;
mutex_lock(&ctx->kdamond_lock);
damon_for_each_target_safe(t, next, ctx) { damon_for_each_target_safe(t, next, ctx) {
put_pid((struct pid *)t->id); put_pid((struct pid *)t->id);
damon_destroy_target(t); damon_destroy_target(t);
} }
mutex_unlock(&ctx->kdamond_lock);
} }
static struct damon_ctx *dbgfs_new_ctx(void) static struct damon_ctx *dbgfs_new_ctx(void)