perf symbols: Do lazy symtab loading for the kernel & modules too
Just like we do with the other DSOs. This also simplifies the kernel_maps setup process, now all that the tools need to do is to call kernel_maps__init and the maps for the modules and kernel will be created, then, later, when kernel_maps__find_symbol() is used, it will also call maps__find_symbol that already checks if the symtab was loaded, loading it if needed. Now if one does 'perf top --hide_kernel_symbols' we won't pay the price of loading the (many) symbols in /proc/kallsyms or vmlinux. Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Frédéric Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> LKML-Reference: <1258757489-5978-4-git-send-email-acme@infradead.org> Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:

committed by
Ingo Molnar

parent
78075caad9
commit
c338aee853
@@ -253,11 +253,11 @@ static int perf_header__adds_write(struct perf_header *self, int fd)
|
||||
|
||||
buildid_sec = &feat_sec[idx++];
|
||||
|
||||
dsos__load_kernel();
|
||||
/*
|
||||
* Read the list of loaded modules with its build_ids
|
||||
* Read the kernel buildid nad the list of loaded modules with
|
||||
* its build_ids:
|
||||
*/
|
||||
dsos__load_modules();
|
||||
kernel_maps__init(true);
|
||||
|
||||
/* Write build-ids */
|
||||
buildid_sec->offset = lseek(fd, 0, SEEK_CUR);
|
||||
|
Reference in New Issue
Block a user