xdp: remove redundant argument to trace_xdp_redirect
Supplying the action argument XDP_REDIRECT to the tracepoint xdp_redirect is redundant as it is only called in-case this action was specified. Remove the argument, but keep "act" member of the tracepoint struct and populate it with XDP_REDIRECT. This makes it easier to write a common bpf_prog processing events. Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:

committed by
David S. Miller

parent
d0fcece770
commit
c31e5a4876
@@ -52,10 +52,10 @@ TRACE_EVENT(xdp_exception,
|
||||
TRACE_EVENT(xdp_redirect,
|
||||
|
||||
TP_PROTO(const struct net_device *dev,
|
||||
const struct bpf_prog *xdp, u32 act,
|
||||
const struct bpf_prog *xdp,
|
||||
int to_index, int err),
|
||||
|
||||
TP_ARGS(dev, xdp, act, to_index, err),
|
||||
TP_ARGS(dev, xdp, to_index, err),
|
||||
|
||||
TP_STRUCT__entry(
|
||||
__array(u8, prog_tag, 8)
|
||||
@@ -68,7 +68,7 @@ TRACE_EVENT(xdp_redirect,
|
||||
TP_fast_assign(
|
||||
BUILD_BUG_ON(sizeof(__entry->prog_tag) != sizeof(xdp->tag));
|
||||
memcpy(__entry->prog_tag, xdp->tag, sizeof(xdp->tag));
|
||||
__entry->act = act;
|
||||
__entry->act = XDP_REDIRECT;
|
||||
__entry->ifindex = dev->ifindex;
|
||||
__entry->to_index = to_index;
|
||||
__entry->err = err;
|
||||
|
Reference in New Issue
Block a user