scsi: ses: Fix possible desc_ptr out-of-bounds accesses
commit 801ab13d50cf3d26170ee073ea8bb4eececb76ab upstream. Sanitize possible desc_ptr out-of-bounds accesses in ses_enclosure_data_process(). Link: https://lore.kernel.org/r/20230202162451.15346-4-thenzl@redhat.com Cc: stable@vger.kernel.org Signed-off-by: Tomas Henzl <thenzl@redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:

committed by
Greg Kroah-Hartman

parent
2ecd344173
commit
c315560e3e
@@ -572,15 +572,19 @@ static void ses_enclosure_data_process(struct enclosure_device *edev,
|
|||||||
int max_desc_len;
|
int max_desc_len;
|
||||||
|
|
||||||
if (desc_ptr) {
|
if (desc_ptr) {
|
||||||
if (desc_ptr >= buf + page7_len) {
|
if (desc_ptr + 3 >= buf + page7_len) {
|
||||||
desc_ptr = NULL;
|
desc_ptr = NULL;
|
||||||
} else {
|
} else {
|
||||||
len = (desc_ptr[2] << 8) + desc_ptr[3];
|
len = (desc_ptr[2] << 8) + desc_ptr[3];
|
||||||
desc_ptr += 4;
|
desc_ptr += 4;
|
||||||
/* Add trailing zero - pushes into
|
if (desc_ptr + len > buf + page7_len)
|
||||||
* reserved space */
|
desc_ptr = NULL;
|
||||||
desc_ptr[len] = '\0';
|
else {
|
||||||
name = desc_ptr;
|
/* Add trailing zero - pushes into
|
||||||
|
* reserved space */
|
||||||
|
desc_ptr[len] = '\0';
|
||||||
|
name = desc_ptr;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (type_ptr[0] == ENCLOSURE_COMPONENT_DEVICE ||
|
if (type_ptr[0] == ENCLOSURE_COMPONENT_DEVICE ||
|
||||||
|
Reference in New Issue
Block a user